Conversation
atian25
approved these changes
Dec 23, 2022
8000
atian25
reviewed
Dec 23, 2022
| } catch(e) { | ||
| // can not match any command | ||
| console.error(`\n ${e.message}, try '${ctx.fuzzyMatched.cmds.join(' ') || bin} --help' for more information.\n`); | ||
| process.exit(1); |
Contributor
There was a problem hiding this comment.
这里后面可能会需要看下，如果 bin 被 programmatic 方式 require 调用时， exit 就把当前进程一起干掉了。
Contributor
There was a problem hiding this comment.
artus-cli 需要有一个 errorhandler，在里面统一决定要不要 exit
Collaborator
Author
There was a problem hiding this comment.
或者先这样，后续看情况再改吧，我发个 1.0.0 版本，这样 artus-cli 的依赖版本就不用改了，0.0.1 这种得改版本麻烦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
应该只有抛错时，再在错误信息后面加上
--help的提示，而不是所有都抛 command not found