10000 Build playground with stable Rust 1.37.0 by lopopolo · Pull Request #23 · artichoke/playground · GitHub
[go: up one dir, main page]
Skip to content

Build playground with stable Rust 1.37.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 12, 2019
Merged

Build playground with stable Rust 1.37.0 #23

merged 5 commits into from
Oct 12, 2019

Conversation

lopopolo
Copy link
Member

Match toolchain specified in artichoke/artichoke.

@lopopolo lopopolo added A-build Area: CI build infrastructure. S-wip Status: This pull request is a work in progress. labels Sep 16, 2019
@lopopolo
Copy link
Member Author

Playground depends on the link_args feature to pass linker args to emscripten.

We might be able to set these using env variables in scripts/activate-wasm-build-env.sh.

@lopopolo
Define linker flags with RUSTFLAGS env variable
be708fa 
This passes the emcc flags directly to rustc.
@lopopolo
Update CONTRIBUTING.md to no longer reference nightly compiler
e5e3c54
@lopopolo
Update to rust 1.38.0
dd185cd
@lopopolo
Revert "Update to rust 1.38.0"
c652ded 
This reverts commit dd185cd.

    shared:ERROR: BINARYEN_TRAP_MODE is not supported by the LLVM wasm backend
@lopopolo
Copy link
Member Author

Tried to push the upgrade all the way to 1.38.0 but emcc fastcomp fails to link at Wasm load time and the upstream compiler fails to link at Rust compile time.

Watching this PR with interest: rust-lang/rust#65251