Update aadhaar.py and pan.py + Add Indian EPIC and GSTIN #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdejong
pushed a commit
that referenced
this pull request
Oct 2, 2021
arthurdejong
pushed a commit
that referenced
this pull request
Oct 2, 2021
|
Hi @vairag22 Thanks for your contributions. I've merged your changes with some modifications. Specifically I reverted some of your changes to Aadhaar and PAN to maintain the current API (e.g. renamed card_holder_type to holder_type but also kept the old name to not break third-party code that relies on that). In the GSTIN module I delegated some of the checking to the PAN module to avoid duplication. Btw, you can easily run the tests locally with tox which should save you some time in pushing commits to test them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aadhaar.pyImproved validation and docstrings, and did other changes as per PEP8pan.pyImproved validation and docstrings, and did other changes as per PEP8epic.pyAdded support for handling EPIC number (Indian voter identification number)gstin.pyAdded support for handling GSTIN (Indian VAT number)