Add payable by cburgdorf · Pull Request #1340 · argotorg/fe

cburgdorf · 2026-03-18T21:36:06Z

Summary

This PR adds a #[payable] attribute for contract init blocks and recv arms, addressing two problems:

Safety: Fe contracts currently accept ETH silently on all entrypoints. Users can lose funds by sending ETH to functions that don't handle it. With #[payable], the compiler injects a CALLVALUE check that
reverts non-payable calls.

ABI correctness: Without an explicit payable signal, JSON ABI generation (planned in a follow-up) would have to mark every function as "stateMutability": "payable" — even pure views and read-only
accessors — since the compiler couldn't distinguish intent. With #[payable], the ABI can correctly derive "payable", "nonpayable", "view", and "pure", which is required for proper integration with
wallets, block explorers, and tools like Foundry or ethers.js.

What's included

Parser: Attribute lists are now parsed before init blocks and recv arms/blocks, with lookahead to distinguish field attributes from init/recv attributes
HIR: attributes field propagated on ContractInit and ContractRecvArm with is_payable() helpers
MIR: New IntrinsicOp::Callvalue wired through ir, fmt, escape analysis, intrinsics mapping, and both codegen backends (Sonatina + Yul)
MIR lowering: CALLVALUE != 0 → revert guards emitted in both lower_init_entrypoint and lower_runtime_entrypoint for non-payable entrypoints
Formatter: fe fmt preserves #[payable] placement on init and recv arms
Validation: Full diagnostic pipeline (PayableError → PayableAttrPass → DiagnosticVoucher) rejects #[payable] on unsupported items (fn, struct, enum, msg variant, recv block, const, extern fn,
etc.) and malformed forms like #[payable(foo)] or #[payable = 1]
Test harness: RuntimeInstance::fund_contract() gives deployed test contracts ETH balance so tests can exercise payable semantics with non-zero value

Example

pub contract Vault {
    #[payable]
    init() {}

    recv VaultMsg {
        #[payable]
        Deposit {} { ... }          // accepts ETH → ABI: "payable"

        GetBalance {} -> u256 { 0 } // reverts if ETH sent → ABI: "pure"
    }
}

Test plan

- Non-payable recv arm works with zero value
- Non-payable recv arm reverts with non-zero value (should_revert)
- Payable recv arm works with zero value
- Payable recv arm accepts non-zero ETH
- Non-payable init reverts with non-zero value (should_revert)
- Payable init accepts non-zero ETH
- Contract without init deploys with zero value
- Contract without init reverts with non-zero value (should_revert)
- MIR snapshot verifies CALLVALUE guards present/absent as expected
- UI tests for #[payable] on unsupported items (fn, struct, enum, const, extern fn)
- UI tests for #[payable] on msg variant (targeted error message)
- UI tests for #[payable] on recv block (targeted error message)
- UI tests for malformed #[payable(foo)] and #[payable = 1]
- All existing tests pass (cargo test --workspace)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09eed45aca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/driver/src/db.rs

crates/parser/src/parser/item.rs

cburgdorf · 2026-03-18T21:46:36Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 09eed45aca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/parser/src/parser/item.rs

crates/driver/src/db.rs

cburgdorf · 2026-03-20T09:58:23Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27431b53b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/hir/src/core/lower/payable.rs

crates/hir/src/core/lower/item.rs

cburgdorf · 2026-03-20T10:28:42Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2fdf84f7ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/parser/src/ast/item.rs

crates/fe/src/test/mod.rs

cburgdorf · 2026-03-20T11:48:09Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3c97dcfc84

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/hir/src/core/lower/contract.rs

crates/codegen/src/yul/emitter/module.rs

cburgdorf · 2026-03-20T13:53:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dfc6904e35

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/parser/src/parser/item.rs

crates/fe/src/test/mod.rs

cburgdorf · 2026-03-20T18:22:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 74c51904d6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/contract-harness/src/lib.rs

crates/hir/src/core/lower/msg.rs

cburgdorf · 2026-03-20T20:28:17Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4414f94e14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/hir/src/core/hir_def/item.rs

crates/fe/src/test/mod.rs

cburgdorf · 2026-03-20T20:50:51Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c26b8cbff7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/fe/src/test/mod.rs

cburgdorf · 2026-03-20T21:14:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 18abf5740d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/codegen/src/yul/emitter/module.rs

cburgdorf · 2026-03-20T21:36:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0eccd92a61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

crates/hir/src/core/hir_def/item.rs

crates/hir/src/analysis/diagnostics.rs

Add a `#[payable]` attribute that explicitly opts contract init blocks and recv arms into accepting ETH. Non-payable entrypoints now get a compiler-injected CALLVALUE check that reverts when msg.value > 0, preventing accidental fund loss. - Parser: parse attribute lists before `init` and recv arm patterns, with lookahead to distinguish field attributes from init/recv attributes - HIR: propagate `attributes` on ContractInit and ContractRecvArm, add `is_payable()` helpers - MIR: add `IntrinsicOp::Callvalue` across ir, fmt, escape analysis, intrinsics mapping, and both codegen backends (Sonatina + Yul) - MIR lowering: emit CALLVALUE != 0 → abort guards in both `lower_init_entrypoint` and `lower_runtime_entrypoint` - Formatter: preserve `#[payable]` on init and recv arms

cburgdorf · 2026-03-20T22:50:15Z

@codex review

chatgpt-codex-connector · 2026-03-20T23:00:16Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cburgdorf force-pushed the add_payable branch from 33a49c3 to 09eed45 Compare March 18, 2026 21:38

cburgdorf marked this pull request as ready for review March 18, 2026 21:38

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

crates/driver/src/db.rs Show resolved Hide resolved

crates/parser/src/parser/item.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 18, 2026

View reviewed changes

crates/parser/src/parser/item.rs Outdated Show resolved Hide resolved

crates/driver/src/db.rs Show resolved Hide resolved

cburgdorf marked this pull request as draft March 19, 2026 23:43

Add method contract harness to fund deployed contract

761714b

cburgdorf force-pushed the add_payable branch from 09eed45 to 27431b5 Compare March 20, 2026 09:40

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/hir/src/core/lower/payable.rs Show resolved Hide resolved

crates/hir/src/core/lower/item.rs Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 27431b5 to 2fdf84f Compare March 20, 2026 10:27

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/parser/src/ast/item.rs Show resolved Hide resolved

crates/fe/src/test/mod.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch 2 times, most recently from aad3577 to 3c97dcf Compare March 20, 2026 11:32

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/hir/src/core/lower/contract.rs Show resolved Hide resolved

crates/codegen/src/yul/emitter/module.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 3c97dcf to dfc6904 Compare March 20, 2026 13:51

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/parser/src/parser/item.rs Show resolved Hide resolved

crates/fe/src/test/mod.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from dfc6904 to 74c5190 Compare March 20, 2026 18:19

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/contract-harness/src/lib.rs Outdated Show resolved Hide resolved

crates/hir/src/core/lower/msg.rs Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 74c5190 to 4414f94 Compare March 20, 2026 20:28

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/hir/src/core/hir_def/item.rs Outdated Show resolved Hide resolved

crates/fe/src/test/mod.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 4414f94 to c26b8cb Compare March 20, 2026 20:50

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/fe/src/test/mod.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from c26b8cb to 18abf57 Compare March 20, 2026 21:13

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/codegen/src/yul/emitter/module.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 18abf57 to 0eccd92 Compare March 20, 2026 21:36

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

crates/hir/src/core/hir_def/item.rs Outdated Show resolved Hide resolved

crates/hir/src/analysis/diagnostics.rs Outdated Show resolved Hide resolved

cburgdorf force-pushed the add_payable branch from 0eccd92 to c0b5e9c Compare March 20, 2026 22:48

cburgdorf marked this pull request as ready for review March 20, 2026 23:05

cburgdorf requested a review from sbillig March 20, 2026 23:05

sbillig approved these changes Mar 20, 2026

View reviewed changes

sbillig merged commit 8389f9e into argotorg:master Mar 20, 2026
6 checks passed

Conversation

Summary

What's included

Example

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants