8000 Changed Available return's values by Rocketct · Pull Request #107 · arduino-libraries/MKRGSM · GitHub
[go: up one dir, main page]
Skip to content

Changed Available return's values #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2020
Merged

Changed Available return's values #107

merged 1 commit into from
Mar 4, 2020

Conversation

Rocketct
Copy link
Contributor
@Rocketct Rocketct commented Mar 4, 2020

This changefix the negative value returned by GSMUDP::available()

fix: #105 and #106

cc:/ @facchinm i have check and seems that the UDP's buffer is not a ring buffer than this change should be enough to fix this two issue could simple take a look if i'm right about the buffer?

@Rocketct
Changed Available return's values
0ee921a 
This changefix the  negative value returned by GSMUDP::available()

fix: arduino-libraries#105 and arduino-libraries#106
@Rocketct Rocketct requested a review from facchinm March 4, 2020 09:30
@facchinm facchinm merged commit 209ec18 into arduino-libraries:master Mar 4, 2020
@Rocketct Rocketct mentioned this pull request Mar 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm Awaiting requested review from facchinm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

udp.available() returning -1 x bytes available
2 participants
@Rocketct @facchinm
0