GenericConnectionhandler redesign of internal structures #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
5f9c616 to
f4fd222
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f674482 to
9dc0fe5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9dc0fe5 to
f34627d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
f34627d to
de0a36d
Compare
…emoving redundant constructor with strings
de0a36d to
2760757
Compare
|
Memory usage change @ 2760757
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective of this PR is to make the implementation of the various connection handler more generic.
with this change it was possible to create a GenericConnection handler that is able to be instantiated in conditions where the kind of connection has to be decided at runtime.
Testing connection handler
mbed core f7ff4114bc0d89f23b45423e049f5bc17114dcbc
renesas core 84d44b8f42bb657d66aa8fdda66f789f294dfddd
samd core 993398cb7a23a4e0f821a73501ae98053773165b