-
Notifications
You must be signed in to change notification settings - Fork 82
Force sending the network configuration when it's updated via Serial #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force sending the network configuration when it's updated via Serial #564
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 94.74% 94.74%
=======================================
Files 32 32
Lines 1483 1483
=======================================
Hits 1405 1405
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Memory usage change @ e42cc79
Click for full report table
Click for full report CSV
|
e42cc79
to
6aac4e0
Compare
Memory usage change @ 6aac4e0
Click for full report table
Click for full report CSV
|
…of network credentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more. 8000
build fails for esp32 and rp2040
6aac4e0
to
2322475
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Memory usage change @ 2322475
Click for full report table
Click for full report CSV
|
The current version does not transmit to the cloud the new network configuration after it has been update with the NetworkConfigurator via Serial.
The PR adds a new state
UpdatePhy
for updating the network configuration. When the network configurations are changed the board is put inDisconnect
state.