fix types & other small issues #366

offspring · 2024-08-26T21:11:13Z

This is a fix for mixing bool with int example

int writeValue()
{
}

bool subscribe () 
{
   return writeValue();
}

CLAassistant · 2024-08-26T21:11:19Z

All committers have signed the CLA.

github-actions · 2024-08-26T21:16:55Z

Memory usage change @ f22ad2e

Board	flash	%	RAM for global variables	%
`arduino:mbed_nano:nano33ble`	💚 -128 - -64	-0.01 - -0.01	0 - 0	0.0 - 0.0
`arduino:mbed_nano:nanorp2040connect`	💚 -96 - -88	-0.0 - -0.0	0 - 0	0.0 - 0.0
`arduino:megaavr:uno2018:mode=on`	💚 -178 - -162	-0.37 - -0.33	0 - 0	0.0 - 0.0
`arduino:renesas_uno:unor4wifi`	💚 -96 - -80	-0.04 - -0.03	0 - 0	0.0 - 0.0
`arduino:samd:mkrwifi1010`	💚 -96 - -88	-0.04 - -0.03	0 - 0	0.0 - 0.0
`arduino:samd:nano_33_iot`	💚 -96 - -88	-0.04 - -0.03	0 - 0	0.0 - 0.0

Click for full report table

Board	`examples/Central/LedControl` flash	%	`examples/Central/PeripheralExplorer` flash	%	`examples/Central/Scan` flash	%	`examples/Central/ScanCallback` flash	%	`examples/Central/SensorTagButton` flash	%	`examples/Peripheral/Advertising/EnhancedAdvertising` flash	%	`examples/Peripheral/Advertising/RawDataAdvertising` flash	%	`examples/Peripheral/BatteryMonitor` flash	%	`examples/Peripheral/ButtonLED` flash	%	%	`examples/Peripheral/CallbackLED` flash	%	`examples/Peripheral/EncryptedBatteryMonitor` flash	%	`examples/Peripheral/LED` flash	%
`arduino:mbed_nano:nano33ble`	-64	-0.01	-64	-0.01	-64	-0.01	-64	-0.01	-64	-0.01	-64	-0.01	-128	-0.01	-64	-0.01	-64	-0.01	0.0	-64	-0.01	-128	-0.01	-64	-0.01
`arduino:mbed_nano:nanorp2040connect`	-88	-0.0	-88	-0.0	-88	-0.0	-88	-0.0	-96	-0.0	-88	-0.0	-88	-0.0	-88	-0.0	-88	-0.0	0.0	-88	-0.0	-88	-0.0	-88	-0.0
`arduino:megaavr:uno2018:mode=on`	-166	-0.34	-166	-0.34	-166	-0.34	-166	-0.34	-162	-0.33	-178	-0.37	-178	-0.37	-166	-0.34	-166	-0.34	0.0	-166	-0.34	-166	-0.34	-166	-0.34
`arduino:renesas_uno:unor4wifi`	-96	-0.04	-96	-0.04	-80	-0.03	-96	-0.04	-96	-0.04	-96	-0.04	-96	-0.04	-96	-0.04	-80	-0.03	0 9F8B .0	-96	-0.04	-96	-0.04	-96	-0.04
`arduino:samd:mkrwifi1010`	-88	-0.03	-88	-0.03	-88	-0.03	-88	-0.03	-96	-0.04	-88	-0.03	-88	-0.03	-88	-0.03	-88	-0.03	0.0	-88	-0.03	-88	-0.03	-88	-0.03
`arduino:samd:nano_33_iot`	-88	-0.03	-88	-0.03	-88	-0.03	-88	-0.03	-96	-0.04	-88	-0.03	-88	-0.03	-88	-0.03	-88	-0.03	0.0	-88	-0.03	-88	-0.03	-88	-0.03

Click for full report CSV

Board,examples/Central/LedControl<br>flash,%,examples/Central/LedControl<br>RAM for global variables,%,examples/Central/PeripheralExplorer<br>flash,%,examples/Central/PeripheralExplorer<br>RAM for global variables,%,examples/Central/Scan<br>flash,%,examples/Central/Scan<br>RAM for global variables,%,examples/Central/ScanCallback<br>flash,%,examples/Central/ScanCallback<br>RAM for global variables,%,examples/Central/SensorTagButton<br>flash,%,examples/Central/SensorTagButton<br>RAM for global variables,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>flash,%,examples/Peripheral/Advertising/EnhancedAdvertising<br>RAM for global variables,%,examples/Peripheral/Advertising/RawDataAdvertising<br>flash,%,examples/Peripheral/Advertising/RawDataAdvertising<br>RAM for global variables,%,examples/Peripheral/BatteryMonitor<br>flash,%,examples/Peripheral/BatteryMonitor<br>RAM for global variables,%,examples/Peripheral/ButtonLED<br>flash,%,examples/Peripheral/ButtonLED<br>RAM for global variables,%,examples/Peripheral/CallbackLED<br>flash,%,examples/Peripheral/CallbackLED<br>RAM for global variables,%,examples/Peripheral/EncryptedBatteryMonitor<br>flash,%,examples/Peripheral/EncryptedBatteryMonitor<br>RAM for global variables,%,examples/Peripheral/LED<br>flash,%,examples/Peripheral/LED<br>RAM for global variables,%
arduino:mbed_nano:nano33ble,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-128,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-64,-0.01,0,0.0,-128,-0.01,0,0.0,-64,-0.01,0,0.0
arduino:mbed_nano:nanorp2040connect,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-96,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0,-88,-0.0,0,0.0
arduino:megaavr:uno2018:mode=on,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-162,-0.33,0,0.0,-178,-0.37,0,0.0,-178,-0.37,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0,-166,-0.34,0,0.0
arduino:renesas_uno:unor4wifi,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-80,-0.03,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-80,-0.03,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0,-96,-0.04,0,0.0
arduino:samd:mkrwifi1010,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-96,-0.04,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0
arduino:samd:nano_33_iot,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-96,-0.04,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0,-88,-0.03,0,0.0

fix types

f22ad2e

per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Sep 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix types & other small issues #366

fix types & other small issues #366

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Are you sure you want to change the base?

fix types & other small issues #366

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!