8000 Bugfix examples by murilopolese · Pull Request #7 · arduino/micropython.js · GitHub
[go: up one dir, main page]
Skip to content

Bugfix examples #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 22, 2023
Merged

Bugfix examples #7

merged 10 commits into from
Jun 22, 2023

Conversation

murilopolese
Copy link
Contributor
  • Refactor examples to use await instead of .then() stack
  • Small cosmetic changes
  • execfile returns output from execution
  • respect chunk_size and chunk_sleep to write to the serial

ubidefeo
ubidefeo requested changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator
@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin(2, Pin.OUT) is specified, and that could not be valid for every board.
Add an ENV Variable for the examples to be run

kittaakos
kittaakos reviewed Jun 16, 2023
View reviewed changes
Copy link
@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 😍 I added a few hints, but none are crucial.

@murilopolese
Copy link
Contributor Author

Pin(2, Pin.OUT) is specified, and that could not be valid for every board. Add an ENV Variable for the examples to be run

@ubidefeo I wonder if there is another way rather than adding a ENV variable... I was using pin 6 because it's the LED on the rp2040 but that messes up on the esp32. Perhaps we skip the pin writing on examples?

ubidefeo
ubidefeo approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator
@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and working

@murilopolese murilopolese merged commit b86f244 into main Jun 22, 2023
@murilopolese murilopolese deleted the bugfix/examples branch June 22, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos left review comments

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murilopolese @kittaakos @ubidefeo
0