10000 Bugfix/write and drain by murilopolese · Pull Request #5 · arduino/micropython.js · GitHub
[go: up one dir, main page]
Skip to content

Bugfix/write and drain #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 7, 2023
Merged

Bugfix/write and drain #5

merged 5 commits into from
Jun 7, 2023

Conversation

murilopolese
Copy link
Contributor

@murilopolese murilopolese requested a review from ubidefeo June 7, 2023 14:32
ubidefeo
ubidefeo requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator
@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the chunk size lower than 256 which is the common max RX buffer size.
Let's go for 200

@murilopolese murilopolese requested a review from ubidefeo June 7, 2023 14:38
ubidefeo
ubidefeo approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator
@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murilopolese murilopolese merged commit b78d9ff into main Jun 7, 2023
@murilopolese murilopolese deleted the bugfix/write-and-drain branch June 7, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murilopolese @ubidefeo
0