8000 Updated cli.js getFile method to leverage binary transfer. by ubidefeo · Pull Request #19 · arduino/micropython.js · GitHub
[go: up one dir, main page]
Skip to content

Updated cli.js getFile method to leverage binary transfer. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Updated cli.js getFile method to leverage binary transfer. #19

merged 1 commit into from
Nov 19, 2024

Conversation

ubidefeo
Copy link
Collaborator

The --getFile method in cli.js was still using the previous implementation of fs_cat rather than fs_cat_binary.
This PR fixes that and allows for binary transfers from the board.

I am not sure if we can later merge this fix in 1.5.0 rather than creating 1.5.1 since cli.js is more of a help/wrap tool to micropython.js.

TBD

@ubidefeo
Updated cli.js getfile method to leverage binary transfer.
1db1b60 
Signed-off-by: ubi de feo <me@ubidefeo.com>
@ubidefeo ubidefeo changed the title Updated cli.js getfile method to leverage binary transfer. Updated cli.js getFile method to leverage binary transfer. Nov 15, 2024
@ubidefeo ubidefeo merged commit d0c7723 into development Nov 19, 2024
1 check passed
@ubidefeo ubidefeo deleted the fix/update-cli-getfile branch November 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murilopolese murilopolese murilopolese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ubidefeo @murilopolese
0