8000 Add command for modifying library data by per1234 · Pull Request #74 · arduino/libraries-repository-engine · GitHub
[go: up one dir, main page]

Skip to content

Add command for modifying library data #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Add command for modifying library data #74

merged 2 commits into from
Aug 26, 2021

Conversation

per1234
Copy link
Contributor
@per1234 per1234 commented Aug 25, 2021

Although much of the Library Manager content is based on the contents of the individual library repositories, some is defined during the library registration, and so a change to this after the time of the registration requires direct action by a maintainer. This procedure will be facilitated by adding the capability to the engine tool's command line interface in the form of the new modify subcommand.

The initial implementation of this command provides for the modification of the library repository URL:

libraries-repository-engine modify --repo-url=NEW_URL LIBRARY_NAME

will change the current repository URL of the library name specified via the positional argument (LIBRARY_NAME) to the new repository URL specified via the --repo-url flag (NEW_URL).

The existing code for doing this was exceptionally convoluted, so rather than exporting the components of that interface,
I added a simple function to serve as the exported interface for this functionality of the package.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 25, 2021
Copy link
Contributor
@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, cannot wait to use it! 🐱

Although much of the Library Manager content is based on the contents of the individual library repositories, some is
defined during the library registration, and so a change to this after the time of the registration requires direct
action by a maintainer. This procedure will be facilitated by adding the capability to the engine tool's command line
interface in the form of the new `modify` subcommand.

The initial implementation of this command provides for the modification of the library repository URL:

```
libraries-repository-engine modify --repo-url=NEW_URL LIBRARY_NAME
```

will change the current repository URL of the library name specified via the positional argument (LIBRARY_NAME) to the
new repository URL specified via the `--repo-url` flag (NEW_URL).
@per1234 per1234 merged commit a8e130b into arduino:main Aug 26, 2021
@per1234 per1234 deleted the modify-command branch August 26, 2021 11:29
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0