8000 Fix example by eclipse1985 · Pull Request #6 · arduino/iot-client-js · GitHub
[go: up one dir, main page]
Skip to content

Fix example #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 2 commits into from
Sep 17, 2019
Merged

Fix example #6

merged 2 commits into from
Sep 17, 2019

Conversation

eclipse1985
Copy link

No description provided.

@eclipse1985 eclipse1985 changed the title Install fixes Fix example and readme Sep 16, 2019
@eclipse1985 eclipse1985 marked this pull request as ready for review September 16, 2019 09:48
@eclipse1985 eclipse1985 requested review from masci and ilcato September 16, 2019 09:48
ilcato
ilcato approved these changes Sep 16, 2019
View reviewed changes
Copy link
@ilcato ilcato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

masci
masci approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor
@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@masci
Copy link
Contributor
masci 8000 commented Sep 16, 2019

Hold on: I skimmed too fast through this, please notice that the README will be overwritten by the generator.

@eclipse1985
Copy link
Author

Hold on: I skimmed too fast through this, please notice that the README will be overwritten by the generator.

Examples too? Do you know why they're basically wrong?

@masci
Copy link
Contributor
masci commented Sep 16, 2019

@eclipse1985
The README and the example are part of the downstream templates we process while generating the clients. While the README has to be there because we want to override the upstream default template, the example is custom code I've produced and could stay here - I'll remove it from the generator repo.

To recap: changes to the README must be ported to the generator repo, any other change can be merged with this PR.

@eclipse1985
Copy link
Author

Ok, I will just move the commit to the proper repo

@eclipse1985 eclipse1985 changed the title Fix example and readme Fix example Sep 16, 2019
@eclipse1985 eclipse1985 mentioned this pull request Sep 16, 2019
Merged
@masci masci merged commit 44c9b45 into master Sep 17, 2019
@masci masci deleted the install_fixes branch September 17, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

@ilcato ilcato ilcato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eclipse1985 @masci @ilcato
0