8000 Allow leading underscore in sketch filenames by per1234 · Pull Request #510 · arduino/arduino-lint · GitHub
[go: up one dir, main page]
Skip to content

Allow leading underscore in sketch filenames #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Allow leading underscore in sketch filenames #510

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d385b
Improve test coverage of SS002 rule function
per1234 Mar 13, 2023
fa2d53e
Allow leading underscore in sketch filenames
per1234 Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
8000
Diff view
Diff view
Prev Previous commit
Allow leading underscore in sketch filenames 
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino
Lint's rule SS002 checks compliance with the specification.

The Arduino Sketch Specification has been changed to allow a leading underscore in sketch folder names and sketch code
filenames so the Arduino Lint rule code must be updated accordingly.
  • Loading branch information
@per1234
per1234 committed Mar 13, 2023
commit fa2d53eb47af0e74055fb4f0660c260563d0fbf7
2 changes: 1 addition & 1 deletion internal/rule/rulefunction/rulefunction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func brokenOutputList(list []string) string {

// validProjectPathBaseName checks whether the provided library folder or sketch filename contains prohibited characters.
func validProjectPathBaseName(name string) bool {
baseNameRegexp := regexp.MustCompile("^[a-zA-Z0-9][a-zA-Z0-9_.-]*$")
baseNameRegexp := regexp.MustCompile("^[a-zA-Z0-9_][a-zA-Z0-9_.-]*$")
return baseNameRegexp.MatchString(name)
}

Expand Down
Empty file added ...l/rule/rulefunction/testdata/sketches/AllowedCharactersInFilenames/_LeadingUnderscore.ino
View file
Open in desktop
Empty file.
0