8000 Enable language packs by AlbyIanna · Pull Request #941 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Enable language packs #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2022
Merged

Enable language packs #941

merged 4 commits into from
Apr 8, 2022

Conversation

AlbyIanna
Copy link
Contributor
@AlbyIanna AlbyIanna commented Apr 4, 2022 •
edited by fstasi
Loading

Motivation

We want to add the language packs whose translations have enough coverage on Transifex

Change description

Install the relative VS Code language pack extensions.

Adding the following languages:

  • Chinese
  • Dutch
  • French
  • German
  • Japanese
  • Turkish

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested review from fstasi, ubidefeo and per1234 April 4, 2022 16:05
@per1234 per1234 linked an issue Apr 6, 2022 that may be closed by this pull request
Can't select language packet in Preferences #771
Closed
per1234
per1234 requested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor
@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this build, I see only the localizations provided by the language pack.

From the mention of the Transifex coverage being a factor in the decision regarding which language packs to install, I anticipated seeing the Arduino IDE-specific localization as well.

Will some additional work be needed on the IDE before we will see #768 have an effect?

@AlbyIanna
Copy link
Contributor Author

When testing this build, I see only the localizations provided by the language pack.

yeah, it's still not working. Trying to figure out why.

msujew
msujew reviewed Apr 6, 2022
View reviewed changes
@AlbyIanna AlbyIanna force-pushed the install-language-packs branch from 1c6e8b0 to 9ed46f9 Compare April 6, 2022 10:46
@AlbyIanna AlbyIanna force-pushed the install-language-packs branch from 9ed46f9 to fc4bba2 Compare April 6, 2022 13:30
@AlbyIanna AlbyIanna requested a review from per1234 April 6, 2022 13:35
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Apr 6, 2022
@AlbyIanna
Copy link
Contributor Author

Now it's working correctly. Please @per1234 @fstasi give it a try

per1234
per1234 requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor
@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see any of the Arduino-specific localizations with the build from fc4bba2:

image

Same results both on Windows 10 and Linux.

@AlbyIanna AlbyIanna force-pushed the install-language-packs branch from fcbc1c3 to b4ba0ac Compare April 7, 2022 14:01
@AlbyIanna AlbyIanna force-pushed the install-language-packs branch from b4ba0ac to 5a48dc5 Compare April 7, 2022 14:23
@AlbyIanna
Copy link
Contributor Author

@per1234 this time I'm really confident that it will work! Please check once again 🙏

@AlbyIanna AlbyIanna requested a review from per1234 April 7, 2022 15:26
per1234
per1234 requested changes Apr 7, 2022
View reviewed changes
per1234
per1234 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor
@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very exciting to see the localization of the IDE.
Thanks Alberto!

And thanks also to the translators for their valuable contributions to the project.

@per1234 per1234 linked an issue Apr 7, 2022 that may be closed by this pull request
Provide Chinese support #627
Closed
@stevisco
Copy link
stevisco commented Apr 8, 2022

this is super cool!

@AlbyIanna AlbyIanna changed the title Install some language packs Enable language packs Apr 8, 2022
@AlbyIanna AlbyIanna merged commit 6176e50 into main Apr 8, 2022
@AlbyIanna AlbyIanna deleted the install-language-packs branch April 8, 2022 12:59
@per1234 per1234 mentioned this pull request Apr 8, 2022
Open
3 tasks
@per1234 per1234 mentioned this pull request Apr 9, 2022
Closed
3 tasks
@kotobuki
Copy link
kotobuki commented Apr 9, 2022

I am a contributor to Japanese, and I'm very excited to see the localised IDE. I found that some of the language resources (e.g. Undo, Redo etc.) are not from Arduino SRL -Arduino IDE 2.0 nor Mbanzi - Arduino IDE 1.5. I found inconsistencies in them, so I want to update them. Where do those localisations come from? 🤔

@per1234
Copy link
Contributor
per1234 commented Apr 9, 2022

Hi @kotobuki. Thanks so much for your contributions and for your attention to the quality of the current localization!

The VS Code "language packs" are used as the localization source where possible so that the Arduino community only needs to localize the Arduino-specific strings rather than having to duplicate the efforts already made for the strings which are shared with VS Code.

The VS Code language pack used for the base Japanese localization is hosted here:

https://github.com/Microsoft/vscode-loc

Note that their system does not allow direct contribution to the content via pull requests to the repository. Instead, it is done by submitting issues to the repository, which will then be acted on by someone from Microsoft.

@kotobuki
Copy link
kotobuki commented Apr 9, 2022

@per1234 Thank you very much for the detailed explanation. I understand. I'll do my best for Arduino IDE specific resources and propose changes to the VSC repository.

@qizaizi
Copy link
qizaizi commented Apr 10, 2022

The plugin directory is in the installation location arduino2.0\Arduino IDE\resources\app\plugins

This was referenced Apr 14, 2022
Open
Closed
@per1234 per1234 mentioned this pull request May 20, 2022
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew left review comments

@per1234 per1234 per1234 approved these changes

@fstasi fstasi Awaiting requested review from fstasi

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees
No one assigned
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't select language packet in Preferences Provide Chinese support
6 participants
@AlbyIanna @stevisco @kotobuki @per1234 @qizaizi @msujew
0