8000 Remove irrelevant trigger from "Compose full changelog" workflow by per1234 · Pull Request #886 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Remove irrelevant trigger from "Compose full changelog" workflow #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Remove irrelevant trigger from "Compose full changelog" workflow #886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Remove irrelevant trigger from "Compose full changelog" workflow 
The "Compose full changelog" GitHub Actions workflow generates a changelog file from the release notes and uploads this
to Arduino's server for display to the user by the IDE updater.

Previously, this workflow could be triggered by either of two events:

- Release creation
- Release edit

To reduce the possibility of endless recursion, GitHub Actions ignores events which are triggered using the
auto-generated `GITHUB_TOKEN` access token. All release creations are done automatically by the "Arduino IDE" GitHub
Actions workflow, which uses this token.

For this reason, the release creation trigger will never be used. Since the behavior of the event being ignored by
GitHub Actions under these conditions is not at all obvious, having the workflow configured for such an irrelevant
trigger can cause confusion.

The workflow will be triggered by the manual edit which is done on every release to format the raw release notes
auto-generated from the commit history. So the fact that the release creation trigger doesn't work is not a problem.
  • Loading branch information
@per1234
per1234 authored Mar 3, 2022
commit 6fe0ac70a33d3f7fc5c3f8e5b0e6885f972ee388
3 changes: 2 additions & 1 deletion .github/workflows/compose-full-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ name: Compose full changelog

on:
release:
types: [created, edited]
types:
- edited

env:
CHANGELOG_ARTIFACTS: changelog
Expand Down
0