8000 Add dialog to insert user fields for board that require them to upload by silvanocerza · Pull Request #550 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Add dialog to insert user fields for board that require them to upload #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 25, 2021
Merged

Add dialog to insert user fields for board that require them to upload #550

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ccd44c2
Rebuild gRPC protocol interfaces
silvanocerza Oct 12, 2021
10d96fc
Implement methods to get user fields for board/port combination
silvanocerza Oct 12, 2021
33de26e
Implement dialog to input board user fields
silvanocerza Oct 18, 2021
53b4f17
Add configure and upload step when uploading to board requiring user …
silvanocerza Oct 18, 2021
97399cf
Disable Sketch > Configure and Upload menu if board doesn't support u…
silvanocerza Oct 18, 2021
624abbe
Fix serial upload not working with all boards
silvanocerza Oct 20, 2021
6f782b5
Update i18n source file
silvanocerza Nov 8, 2021
286a687
fix user fields UI
Nov 24, 2021
a330d65
regenerate cli protocol
Nov 24, 2021
8fa5705
fix localisation
Nov 24, 2021
581979c
check if user fields are empty
Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix serial upload not working with all boards
  • Loading branch information
@silvanocerza
silvanocerza authored and Alberto Iannaccone committed Nov 24, 2021
commit 624abbe0b0315f4e432f8fcda86bbaed8fc926d2
5 changes: 3 additions & 2 deletions arduino-ide-extension/src/browser/contributions/upload-sketch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,8 +230,9 @@ export class UploadSketch extends SketchContribution {
const optimizeForDebug = this.editorMode.compileForDebug;
const { selectedPort } = boardsConfig;
const port = selectedPort;
const userFields = this.cachedUserFields.get(this.selectedFqbnAddress());
if (!userFields) {
const userFields =
this.cachedUserFields.get(this.selectedFqbnAddress()) ?? [];
if (userFields.length === 0 && this.boardRequiresUserFields) {
this.messageService.error(
nls.localize(
'arduino/sketch/userFieldsNotFoundError',
Expand Down
0