8000 [ATL-1599] [ATL-1416] Upgrade Theia to 1.18.0 by fstasi · Pull Request #489 · arduino/arduino-ide · GitHub
[go: up one dir, main page]

Skip to content

[ATL-1599] [ATL-1416] Upgrade Theia to 1.18.0 #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Oct 6, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated node-gyp
  • Loading branch information
fstasi committed Sep 2, 2021
commit 03acb589a37b7c5cec5687bfffcd3f2e9e02ff6d
1 change: 1 addition & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ jobs:

elif [ "${{ runner.OS }}" = "Windows" ]; then
export CSC_LINK="${{ runner.temp }}/signing_certificate.pfx"
npm config set msvs_version 2017 --global
echo "${{ secrets.WINDOWS_SIGNING_CERTIFICATE_PFX }}" | base64 --decode > "$CSC_LINK"

export CSC_KEY_PASSWORD="${{ secrets.WINDOWS_SIGNING_CERTIFICATE_PASSWORD }}"
Expand Down
2 changes: 1 addition & 1 deletion electron/packager/conf-node-gyp.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

npm install --global node-gyp@6.0.1
npm install --global node-gyp@7.0.0

if [ "$OSTYPE" = "cygwin" ] || [ "$OSTYPE" = "msys" ]; then
npm config set node_gyp "`npm prefix -g`\node_modules\node-gyp\bin\node-gyp.js"
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6035,7 +6035,7 @@ electron-rebuild@^1.8.6:
detect-libc "^1.0.3"
fs-extra "^8.1.0"
node-abi "^2.11.0"
node-gyp "^6.0.1"
node-gyp "^7.0.0"
ora "^3.4.0"
spawn-rx "^3.0.0"
yargs "^14.2.0"
Expand Down Expand Up @@ -10027,7 +10027,7 @@ npm-lifecycle@^3.1.2:
dependencies:
byline "^5.0.0"
graceful-fs "^4.1.15"
node-gyp "^5.0.2"
node-gyp "^7.0.0"
resolve-from "^4.0.0"
slide "^1.1.6"
uid-number "0.0.6"
Expand Down
0