fix: add missing linux dependencies after ubuntu-latest runner update #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
per1234
requested changes
Feb 28, 2025
d32178b to
9e8d2fc
Compare
Install `libx11-dev`, `libxkbfile-dev`, `libsecret-1-dev` libraries as the most recent update to ubuntu-latest does not include them Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
9e8d2fc to
34b5a2f
Compare
4 tasks
per1234
approved these changes
Feb 28, 2025
giacomocusinato
added a commit
that referenced
this pull request
Apr 1, 2025
giacomocusinato
added a commit
that referenced
this pull request
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ubuntu 24.04 is the new default version for Ubuntu latest runner actions/runner-images#10636
Ubuntu 24.04 no longer includes the following dependencies:
libx11-dev,libxkbfile-devrequired bynative-keymaplibsecret-1-devrequired bykeytarpackage.Note that
keytaris now deprecated and it's a dependency on both IDE2 and Theia eclipse-theia/theia#13593Change description
Manually install missing dependencies in CI workflows only for Linux
Other information
Adopted in favour of #2649
Reviewer checklist