10000 fix(plugin): decouple state update from the LS by dankeboy36 · Pull Request #2643 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

fix(plugin): decouple state update from the LS #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 10, 2025
Merged

fix(plugin): decouple state update from the LS #2643

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bd623db
fix(plugin): decouple state update from the LS
dankeboy36 Feb 25, 2025
af4ab3d
fix: install missing libx11-dev and libxkbfile-dev
dankeboy36 Feb 25, 2025
6d499dd
fix: pick better GH step name
dankeboy36 Feb 25, 2025
d064ee6
fix: install the required dependencies on Linux
dankeboy36 Feb 25, 2025
dc6bb6d
fix(revert): do not manually install deps on Linux
dankeboy36 Feb 27, 2025
b11bde1
chore: pin `ubuntu-22.04` for linux actions
giacomocusinato Feb 27, 2025
1f1d749
fix: restore accidentally removed dispose on finally
dankeboy36 Feb 27, 2025
bab2e58
fix(test): align mock naming :lipstick:
dankeboy36 Feb 27, 2025
d53d8b9
fix: let the ino contribution notify the LS
dankeboy36 Feb 27, 2025
64fdaba
fix(test): emit the new compiler summary state
dankeboy36 Feb 27, 2025
b04bfa4
Merge branch 'main' into fix/2642/arduino-state-does-not-depend-on-ino
dankeboy36 Mar 2, 2025
0daa919
chore(revert): unpin linux version, use latest
dankeboy36 Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(revert): unpin linux version, use latest 
revert of b11bde1

Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
  • Loading branch information
@dankeboy36
dankeboy36 committed Mar 2, 2025
commit 0daa919ad457d628032aa9a0338912f2d9ff8739
20 changes: 10 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ env:
name: Windows_X86-64_zip
- config:
name: Linux
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
container: |
{
\"image\": \"ghcr.io/arduino/arduino-ide/linux:main\"
Expand Down Expand Up @@ -140,7 +140,7 @@ env:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
result: ${{ steps.determination.outputs.result }}
permissions: {}
Expand All @@ -166,7 +166,7 @@ jobs:
build-type-determination:
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
is-release: ${{ steps.determination.outputs.is-release }}
is-nightly: ${{ steps.determination.outputs.is-nightly }}
Expand Down Expand Up @@ -207,7 +207,7 @@ jobs:

select-targets:
needs: build-type-determination
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
artifact-matrix: ${{ steps.assemble.outputs.artifact-matrix }}
build-matrix: ${{ steps.assemble.outputs.build-matrix }}
Expand Down Expand Up @@ -434,7 +434,7 @@ jobs:
- select-targets
- build
if: needs.select-targets.outputs.merge-channel-files == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions: {}
steps:
- name: Set environment variables
Expand Down Expand Up @@ -498,7 +498,7 @@ jobs:
- select-targets
- build
if: always() && needs.build.result != 'skipped'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

env:
BUILD_ARTIFACTS_FOLDER: build-artifacts
Expand All @@ -524,7 +524,7 @@ jobs:
needs:
- build-type-determination
- build
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
BODY: ${{ steps.changelog.outputs.BODY }}
steps:
Expand Down Expand Up @@ -583,7 +583,7 @@ jobs:
needs.changelog.result == 'success' &&
needs.build-type-determination.outputs.publish-to-s3 == 'true' &&
needs.build-type-determination.outputs.is-nightly == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

env:
ARTIFACTS_FOLDER: build-artifacts
Expand Down Expand Up @@ -620,7 +620,7 @@ jobs:
) &&
needs.changelog.result == 'success' &&
needs.build-type-determination.outputs.is-release == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

env:
ARTIFACTS_FOLDER: build-artifacts
Expand Down Expand Up @@ -668,7 +668,7 @@ jobs:
- release
- artifacts
if: always() && needs.build.result != 'skipped'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

steps:
- name: Remove unneeded job transfer artifacts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-certificates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
result: ${{ steps.determination.outputs.result }}
steps:
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
name: ${{ matrix.certificate.identifier }}
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
strategy:
fail-fast: false

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-containers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ on:
jobs:
run:
name: Run (${{ matrix.image.path }})
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions: {}
services:
registry:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-i18n-task.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
outputs:
result: ${{ steps.determination.outputs.result }}
permissions: {}
Expand Down Expand Up @@ -52,7 +52,7 @@ jobs:
check:
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

steps:
- name: Checkout repository
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-javascript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions: {}
outputs:
result: ${{ steps.determination.outputs.result }}
Expand All @@ -59,7 +59,7 @@ jobs:
check:
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions:
contents: read

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/check-yarn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions: {}
outputs:
result: ${{ steps.determination.outputs.result }}
Expand All @@ -52,7 +52,7 @@ jobs:
name: check-sync (${{ matrix.project.path }})
needs: run-determination
if: needs.run-determination.outputs.result == 'true'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions:
contents: read

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compose-full-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:
jobs:
create-changelog:
if: github.repository == 'arduino/arduino-ide'
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/i18n-nightly-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
push-to-transifex:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/i18n-weekly-pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:

jobs:
pull-from-transifex:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/push-container-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
github.event_name == 'pull_request' &&
github.event.pull_request.head.repo.full_name == 'arduino/arduino-ide'
)
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/sync-labels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:

jobs:
check:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

steps:
- name: Checkout repository
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:

download:
needs: check
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

strategy:
matrix:
Expand All @@ -81,7 +81,7 @@ jobs:

sync:
needs: download
runs-on: ubuntu-22.04
runs-on: ubuntu-latest

steps:
- name: Set environment variables
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-javascript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ on:

jobs:
run-determination:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
permissions: { 57AE }
outputs:
result: ${{ steps.determination.outputs.result }}
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
- path: .
operating-system:
- macos-latest
- ubuntu-22.04
- ubuntu-latest
- windows-latest

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/themes-weekly-pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ env:

jobs:
pull-from-jsonbin:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
Loading
0