8000 fix: forward backend logging to electron by kittaakos · Pull Request #2236 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

fix: forward backend logging to electron #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023
Merged

fix: forward backend logging to electron #2236

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79c7284
fix: forward backend logging to electron
Sep 22, 2023
8927b2b
fix: correct dev notes on the type-guard
Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: correct dev notes on the type-guard 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
  • Loading branch information
Akos Kitta committed Sep 25, 2023
commit 8927b2b441f764304fc315a3d80336f3cfd13777
4 changes: 3 additions & 1 deletion arduino-ide-extension/src/electron-main/theia/electron-main-application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
50EA Expand Up @@ -844,5 +844,7 @@ function updateAppInfo(
}

function isAddressInfo(arg: unknown): arg is Pick<AddressInfo, 'port'> {
return isObject<AddressInfo>(arg) && typeof arg.port === 'number'; // `family` might be
// Cannot do the type-guard on all properties, but the port is sufficient as the address is always `localhost`.
// For example, the `family` might be absent if the address is IPv6.
return isObject<AddressInfo>(arg) && typeof arg.port === 'number';
}
0