chore(deps): update to theia@1.41.0

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
arduino · kittaakos · Sep 29, 2023 · Sep 1, 2023 · Sep 12, 2023 · Sep 12, 2023
commit 92a1352d132deaded2326eab62c04f8e2ddd354f
diff --git a/arduino-ide-extension/package.json b/arduino-ide-extension/package.json
@@ -24,27 +24,27 @@
   },
   "dependencies": {
     "@grpc/grpc-js": "^1.8.14",
-    "@theia/application-package": "1.39.0",
-    "@theia/core": "1.39.0",
-    "@theia/debug": "1.39.0",
-    "@theia/editor": "1.39.0",
-    "@theia/electron": "1.39.0",
-    "@theia/filesystem": "1.39.0",
-    "@theia/keymaps": "1.39.0",
-    "@theia/markers": "1.39.0",
-    "@theia/messages": "1.39.0",
-    "@theia/monaco": "1.39.0",
+    "@theia/application-package": "1.41.0",
+    "@theia/core": "1.41.0",
+    "@theia/debug": "1.41.0",
+    "@theia/editor": "1.41.0",
+    "@theia/electron": "1.41.0",
+    "@theia/filesystem": "1.41.0",
+    "@theia/keymaps": "1.41.0",
+    "@theia/markers": "1.41.0",
+    "@theia/messages": "1.41.0",
+    "@theia/monaco": "1.41.0",
     "@theia/monaco-editor-core": "1.72.3",
-    "@theia/navigator": "1.39.0",
-    "@theia/outline-view": "1.39.0",
-    "@theia/output": "1.39.0",
-    "@theia/plugin-ext": "1.39.0",
-    "@theia/preferences": "1.39.0",
-    "@theia/scm": "1.39.0",
-    "@theia/search-in-workspace": "1.39.0",
-    "@theia/terminal": "1.39.0",
-    "@theia/typehierarchy": "1.39.0",
-    "@theia/workspace": "1.39.0",
+    "@theia/navigator": "1.41.0",
+    "@theia/outline-view": "1.41.0",
+    "@theia/output": "1.41.0",
+    "@theia/plugin-ext": "1.41.0",
+    "@theia/preferences": "1.41.0",
+    "@theia/scm": "1.41.0",
+    "@theia/search-in-workspace": "1.41.0",
+    "@theia/terminal": "1.41.0",
+    "@theia/typehierarchy": "1.41.0",
+    "@theia/workspace": "1.41.0",
     "@tippyjs/react": "^4.2.5",
     "@types/auth0-js": "^9.14.0",
     "@types/btoa": "^1.2.3",

diff --git a/arduino-ide-extension/src/node/auth/authentication-server.ts b/arduino-ide-extension/src/node/auth/authentication-server.ts
@@ -29,7 +29,7 @@ export function createServer(
 }
 
 export async function startServer(server: http.Server): Promise<string> {
-  let portTimer: NodeJS.Timer;
+  let portTimer: NodeJS.Timeout;
 
   function cancelPortTimer() {
     clearTimeout(portTimer);

diff --git a/arduino-ide-extension/src/node/theia/plugin-ext/plugin-reader.ts b/arduino-ide-extension/src/node/theia/plugin-ext/plugin-reader.ts
@@ -7,13 +7,14 @@ import { HostedPluginReader as TheiaHostedPluginReader } from '@theia/plugin-ext
 
 @injectable()
 export class HostedPluginReader extends TheiaHostedPluginReader {
-  override readContribution(
+  override async readContribution(
     plugin: PluginPackage
-  ): PluginContribution | undefined {
+  ): Promise<PluginContribution | undefined> {
     const scanner = this.scanner.getScanner(plugin);
-    const contributions = scanner.getContribution(plugin);
+    const contributions = await scanner.getContribution(plugin);
     return this.filterContribution(plugin.name, contributions);
   }
+
   private filterContribution(
     pluginName: string,
     contributions: PluginContribution | undefined

diff --git a/arduino-ide-extension/src/node/theia/workspace/default-workspace-server.ts b/arduino-ide-extension/src/node/theia/workspace/default-workspace-server.ts
@@ -1,8 +1,7 @@
-import { promises as fs, constants } from 'node:fs';
-import { injectable, inject } from '@theia/core/shared/inversify';
+import { FileUri } from '@theia/core/lib/node';
+import { inject, injectable } from '@theia/core/shared/inversify';
 import { DefaultWorkspaceServer as TheiaDefaultWorkspaceServer } from '@theia/workspace/lib/node/default-workspace-server';
 import { SketchesService } from '../../../common/protocol';
-import { FileUri } from '@theia/core/lib/node';
 import { IsTempSketch } from '../../is-temp-sketch';
 
 @injectable()
@@ -21,26 +20,6 @@ export class DefaultWorkspaceServer extends TheiaDefaultWorkspaceServer {
     return uri;
   }
 
-  /**
-   * This is the async re-implementation of the default Theia behavior.
-   */
-  override async getRecentWorkspaces(): Promise<string[]> {
-    const listUri: string[] = [];
-    const data = await this.readRecentWorkspacePathsFromUserHome();
-    if (data && data.recentRoots) {
-      await Promise.all(
-        data.recentRoots
-          .filter((element) => Boolean(element))
-          .map(async (element) => {
-            if (await this.exists(element)) {
-              listUri.push(element);
-            }
-          })
-          );
-    }
-    return listUri;
-  }
-
   protected override async writeToUserHome(
     data: RecentWorkspacePathsData
   ): Promise<void> {
@@ -69,15 +48,6 @@ export class DefaultWorkspaceServer extends TheiaDefaultWorkspaceServer {
       recentRoots,
     };
   }
-
-  private async exists(uri: string): Promise<boolean> {
-    try {
-      await fs.access(FileUri.fsPath(uri), constants.R_OK | constants.W_OK);
-      return true;
-    } catch {
-      return false;
-    }
-  }
 }
 
 // Remove after https://github.com/eclipse-theia/theia/pull/11603

diff --git a/electron-app/package.json b/electron-app/package.json
@@ -5,24 +5,24 @@
   "license": "AGPL-3.0-or-later",
   "main": "./src-gen/backend/electron-main.js",
   "dependencies": {
-    "@theia/core": "1.39.0",
-    "@theia/debug": "1.39.0",
-    "@theia/editor": "1.39.0",
-    "@theia/electron": "1.39.0",
-    "@theia/filesystem": "1.39.0",
-    "@theia/keymaps": "1.39.0",
-    "@theia/messages": "1.39.0",
-    "@theia/monaco": "1.39.0",
-    "@theia/navigator": "1.39.0",
-    "@theia/plugin-ext": "1.39.0",
-    "@theia/plugin-ext-vscode": "1.39.0",
-    "@theia/preferences": "1.39.0",
-    "@theia/terminal": "1.39.0",
-    "@theia/workspace": "1.39.0",
+    "@theia/core": "1.41.0",
+    "@theia/debug": "1.41.0",
+    "@theia/editor": "1.41.0",
+    "@theia/electron": "1.41.0",
+    "@theia/filesystem": "1.41.0",
+    "@theia/keymaps": "1.41.0",
+    "@theia/messages": "1.41.0",
+    "@theia/monaco": "1.41.0",
+    "@theia/navigator": "1.41.0",
+    "@theia/plugin-ext": "1.41.0",
+    "@theia/plugin-ext-vscode": "1.41.0",
+    "@theia/preferences": "1.41.0",
+    "@theia/terminal": "1.41.0",
+    "@theia/workspace": "1.41.0",
     "arduino-ide-extension": "2.2.2"
   },
   "devDependencies": {
-    "@theia/cli": "1.39.0",
+    "@theia/cli": "1.41.0",
     "7zip-min": "^1.4.4",
     "chmodr": "^1.2.0",
     "compression-webpack-plugin": "^9.0.0",

diff --git a/electron-app/webpack.base.js b/electron-app/webpack.base.js
@@ -4,11 +4,10 @@
 const chmodr = require('chmodr');
 const CopyWebpackPlugin = require('copy-webpack-plugin');
 const path = require('node:path');
-const fs = require('node:fs/promises');
-
-const isWindows = process.platform === 'win32';
-const isMacOS = process.platform === 'darwin';
 
+/**
+ * @param {string} target the name of the `npm` package to resolve.
+ */
 function resolvePackagePath(target, baseDir = __dirname) {
   const resolvePackageJsonPath = require('resolve-package-path');
   const packageJsonPath = resolvePackageJsonPath(target, baseDir);
@@ -23,9 +22,11 @@ function resolvePackagePath(target, baseDir = __dirname) {
 // restore file permissions after webpack copy
 // https://github.com/webpack-contrib/copy-webpack-plugin/issues/35#issuecomment-1407280257
 class PermissionsPlugin {
-  constructor(targetPath, patchTheia12780 = false) {
+  /**
+   * @param {string} targetPath
+   */
+  constructor(targetPath) {
     this.targetPath = targetPath;
-    this.patchTheia12780 = patchTheia12780;
   }
 
   /**
@@ -34,20 +35,6 @@ class PermissionsPlugin {
   apply(compiler) {
     compiler.hooks.afterEmit.tap('PermissionsPlugin', () => {
       return new Promise(async (resolve, reject) => {
-        if (this.patchTheia12780) {
-          let trashBinaryFilename = undefined;
-          if (isWindows) {
-            trashBinaryFilename = 'windows-trash.exe';
-          } else if (isMacOS) {
-            trashBinaryFilename = 'macos-trash';
-          }
-          if (trashBinaryFilename) {
-            await fs.chmod(
-              path.join(__dirname, 'lib', 'backend', trashBinaryFilename),
-              0o755
-            );
-          }
-        }
         chmodr(this.targetPath, 0o755, (err) =>
           err ? reject(err) : resolve(undefined)
         );
@@ -59,18 +46,9 @@ class PermissionsPlugin {
 /**
  * Creates webpack plugins to copy all required resources (binaries, plotter app, translation files, etc.) to the appropriate location.
  * @param {string} targetPath where to copy the resources
- * @param {boolean|undefined} [patchTheia12780=true] to apply patch for https://github.com/eclipse-theia/theia/issues/12780. Only required in the production app.
  * @param {string|undefined} [baseDir=__dirname] to calculate the modules from. Defaults to `__dirname`
  */
-function createCopyArduinoResourcesPlugins(
-  targetPath,
-  patchTheia12780 = false,
-  baseDir = __dirname
-) {
-  const trashBinariesPath = path.join(
-    resolvePackagePath('trash', baseDir),
-    'lib'
-  );
+function createCopyArduinoResourcesPlugins(targetPath, baseDir = __dirname) {
   const copyOptions = {
     patterns: [
       // binaries
@@ -96,25 +74,9 @@ function createCopyArduinoResourcesPlugins(
       },
     ],
   };
-
-  if (patchTheia12780) {
-    // workaround for https://github.com/eclipse-theia/theia/issues/12780
-    // copy the Windows (`windows-trash.exe`) and macOS (`macos-trash`) executables for `trash`
-    if (isWindows) {
-      copyOptions.patterns.push({
-        from: path.join(trashBinariesPath, 'windows-trash.exe'),
-        to: path.resolve(__dirname, 'lib', 'backend'),
-      });
-    } else if (isMacOS) {
-      copyOptions.patterns.push({
-        from: path.join(trashBinariesPath, 'macos-trash'),
-        to: path.resolve(__dirname, 'lib', 'backend'),
-      });
-    }
-  }
   return [
     new CopyWebpackPlugin(copyOptions),
-    new PermissionsPlugin(targetPath, patchTheia12780),
+    new PermissionsPlugin(targetPath),
   ];
 }
 

diff --git a/electron-app/webpack.config.js b/electron-app/webpack.config.js
@@ -21,20 +21,11 @@ mainWindowConfig.plugins?.push(
 );
 const preloadConfig = frontend[2];
 
-// Taken from https://github.com/eclipse-theia/theia-blueprint/blob/022878d5488c47650fb17b5fdf49a28be88465fe/applications/electron/webpack.config.js#L18-L21
-if (process.platform !== 'win32') {
-  // For some reason, blueprint wants to bundle the `.node` files directly without going through `@vscode/windows-ca-certs`
-  backend.ignoredResources.add(
-    '@vscode/windows-ca-certs/build/Release/crypt32.node'
-  );
-}
-
 // Copy all the IDE2 binaries and the plotter web app.
 // XXX: For whatever reason it is important to use `unshift` instead of `push`, and execute the additional webpack plugins before the Theia contributed ones kick in. Otherwise ours do not work.
 backend.config.plugins.unshift(
   ...createCopyArduinoResourcesPlugins(
-    path.resolve(__dirname, 'lib', 'backend', 'resources'),
-    true
+    path.resolve(__dirname, 'lib', 'backend', 'resources')
   )
 );
 

diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "node": ">=18.17.0 <21"
   },
   "devDependencies": {
-    "@theia/cli": "1.39.0",
+    "@theia/cli": "1.41.0",
     "@typescript-eslint/eslint-plugin": "^5.59.0",
     "@typescript-eslint/parser": "^5.59.0",
     "@xhmikosr/downloader": "^13.0.1",