10000 Error message if upload is not possible by francescospissu · Pull Request #1353 · arduino/arduino-ide · GitHub
[go: up one dir, main page]
Skip to content

Error message if upload is not possible #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2022
Merged

Error message if upload is not possible #1353

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cc4931
remove return if fqbn address is not available
francescospissu Aug 24, 2022
5b6bfe1
update error message
francescospissu Aug 25, 2022
99d1a7b
update includes
francescospissu Aug 25, 2022
922963e
add key check in board user fields logic
francescospissu Aug 25, 2022
d4a8ad8
add localization for no board selected msg
francescospissu Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
8000
Diff view
Next Next commit
remove return if fqbn address is not available
  • Loading branch information
@francescospissu
francescospissu committed Aug 24, 2022
commit 9cc49319df60ef08242933fb8374ea6490db213b
3 changes: 0 additions & 3 deletions arduino-ide-extension/src/browser/contributions/upload-sketch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ export class UploadSketch extends CoreServiceContribution {
registry.registerCommand(UploadSketch.Commands.UPLOAD_SKETCH, {
execute: async () => {
const key = this.selectedFqbnAddress();
if (!key) {
return;
}
if (this.boardRequiresUserFields && !this.cachedUserFields.has(key)) {
// Deep clone the array of board fields to avoid editing the cached ones
this.userFieldsDialog.value = (
Expand Down
0