8000 Generate `plugin_firmware_index.json` with new boards data by MatteoPologruto · Pull Request #172 · arduino/arduino-fwuploader · GitHub
[go: up one dir, main page]
Skip to content

Generate plugin_firmware_index.json with new boards data #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 12, 2023
Merged

Generate plugin_firmware_index.json with new boards data #172

merged 11 commits into from
Jul 12, 2023

Conversation

MatteoPologruto
Copy link
Contributor
@MatteoPologruto MatteoPologruto commented Jul 3, 2023 •
edited
Loading

Generate a new index for new boards named plugin_firmware_index.json, with the boards as the following entry:

  {
    "fqbn": "arduino:renesas_uno:unor4wifi",
    "firmware": [
      {
        "version": "0.1.0",
        "url": "https://downloads.arduino.cc/arduino-fwuploader/firmwares/ESP32-S3/0.1.0/ESP32-S3.bin",
        "checksum": "SHA-256:37c4f003373448504d49d5e3c1754d1d90b9bba3f8f3b529b435d331ca6900b1",
        "size": "3951616",
        "module": "ESP32-S3"
      },
      {
        "version": "0.2.0",
        "url": "https://downloads.arduino.cc/arduino-fwuploader/firmwares/ESP32-S3/0.2.0/ESP32-S3.bin",
        "checksum": "SHA-256:cb535826ba96d4f51bdac33d252c24bd9c692a7bef56710ec0431979cef09fc3",
        "size": "3951616",
        "module": "ESP32-S3"
      }
    ],
    "uploader_plugin": "arduino:uno-r4-wifi-fwuploader@1.0.0",
    "additional_tools": [
      "arduino:espflash@2.0.0",
      "arduino:bossac@1.9.1-arduino5"
    ],
    "module": "ESP32-S3",
    "name": "Arduino Uno R4 WiFi"
  }

The old module_firmware_index.json can still be generated using the --no-new flag when launching the script.

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 3, 2023
@MatteoPologruto MatteoPologruto self-assigned this Jul 3, 2023
umbynos
umbynos reviewed Jul 5, 2023
View reviewed changes
umbynos
umbynos reviewed Jul 5, 2023
View reviewed changes
@MatteoPologruto MatteoPologruto force-pushed the add-uno-r4-wifi branch 3 times, most recently from 800402b to 0c851e5 Compare July 5, 2023 15:10
@umbynos
Copy link
Contributor
umbynos commented Jul 6, 2023 •
edited
Loading

I replaced the "placeholder firmware" with:

I also uploaded them to S3.

@umbynos
Copy link
Contributor
umbynos commented Jul 10, 2023

Actually with @cmaglie we decided it was best to have two separate json files. The old module_firmware_index.json and a new plugin_firmware_index.json file: containing only the new plugin supported boards. This way we can avoid showing unsupported board in case of arduino-fwuploader firmware list with an old version of the fw uploader. The generator.py and the CI should consider this.

@MatteoPologruto MatteoPologruto force-pushed the add-uno-r4-wifi branch 3 times, most recently from 5c9f3d2 to a649419 Compare July 12, 2023 08:18
@MatteoPologruto MatteoPologruto marked this pull request as ready for review July 12, 2023 08:36
@MatteoPologruto MatteoPologruto changed the title Add arduino uno r4 data to module_firmware_index.json Generate plugin_firmware_index.json with new boards data Jul 12, 2023
umbynos
umbynos suggested changes Jul 12, 2023
View reviewed changes
@MatteoPologruto MatteoPologruto merged commit 385f7d0 into arduino:main Jul 12, 2023
@MatteoPologruto MatteoPologruto deleted the add-uno-r4-wifi branch July 12, 2023 09:54
@per1234 per1234 mentioned this pull request Aug 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@umbynos umbynos umbynos approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

Assignees

@MatteoPologruto MatteoPologruto

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatteoPologruto @umbynos @alessio-perugini
0