bump go version to GO 1.18 #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
approved these changes
Oct 14, 2022
per1234
requested changes
Oct 14, 2022
There was a problem hiding this comment.
I recommend updating the go directive in go.mod as well.
Go 1.18 is now the standardized version of Go to be used for all development and validation of the project. I think it makes most sense to communicate this fact via the go directive, even if 1.18 may not be absolutely required at this time. I don't think sufficient resources are available to ensure compatibility with previous Go versions.
per1234
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed here #144 (comment) Should mitigate #150