8000 Added option to disable integrity checks in `core install` (for development purposes) by cmaglie · Pull Request #2740 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Added option to disable integrity checks in core install (for development purposes) #2740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Added option to disable integrity checks in core install (for development purposes) #2740

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bbe93b
Added 'enable_unsafe_install' option for platforms.
cmaglie Oct 29, 2024
2925682
Updated documentation
cmaglie Oct 29, 2024
be0b725
Do not skip platform index loading if size is invalid or missing
cmaglie Oct 29, 2024
4f3d245
Added integration test
cmaglie Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not skip platform index loading if size is invalid or missing
  • Loading branch information
@cmaglie
cmaglie committed Jan 13, 2025
commit be0b72575e6a9749446796b432406f056a27ce34
11 changes: 5 additions & 6 deletions internal/arduino/cores/packageindex/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,12 @@ package packageindex

import (
"encoding/json"
"errors"
"fmt"
"slices"

"github.com/arduino/arduino-cli/internal/arduino/cores"
"github.com/arduino/arduino-cli/internal/arduino/resources"
"github.com/arduino/arduino-cli/internal/arduino/security"
"github.com/arduino/arduino-cli/internal/i18n"
"github.com/arduino/go-paths-helper"
easyjson "github.com/mailru/easyjson"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -273,14 +271,15 @@ func (inPlatformRelease indexPlatformRelease) extractPlatformIn(outPackage *core
outPlatform.Deprecated = inPlatformRelease.Deprecated
}

size, err := inPlatformRelease.Size.Int64()
if err != nil {
return errors.New(i18n.Tr("invalid platform archive size: %s", err))
}
outPlatformRelease := outPlatform.GetOrCreateRelease(inPlatformRelease.Version)
outPlatformRelease.Name = inPlatformRelease.Name
outPlatformRelease.Category = inPlatformRelease.Category
outPlatformRelease.IsTrusted = trusted
size, err := inPlatformRelease.Size.Int64()
if err != nil {
logrus.Warningf("invalid platform %s archive size: %s", outPlatformRelease, err)
size = 0
}
outPlatformRelease.Resource = &resources.DownloadResource{
ArchiveFileName: inPlatformRelease.ArchiveFileName,
Checksum: inPlatformRelease.Checksum,
Expand Down
0