10000 Fixed locales (translations) not being detected with default config by cmaglie · Pull Request #2724 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Fixed locales (translations) not being detected with default config #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Fixed locales (translations) not being detected with default config #2724

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1625f0c
Fixed locales (translations) not being detected with default config
cmaglie Oct 7, 2024
58a08f1
Fixed integration test
cmaglie Oct 7, 2024
9d9afb8
Apply i18n settings only if specified
cmaglie Oct 15, 2024
317b3de
Fixed settings.GetLocale()
cmaglie Nov 6, 2024
a6e3276
Do not print directly to stdout if locale-detection fails (windows)
cmaglie Nov 6, 2024
01e72e3
Give LANG env var priority (windows)
cmaglie Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed settings.GetLocale()
  • Loading branch information
@cmaglie
cmaglie committed Nov 6, 2024
commit 317b3de27c30e6be36e482f0e71881bdd06cb3c0
3 changes: 3 additions & 0 deletions internal/cli/configuration/locale.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
package configuration

func (s *Settings) Locale() string {
if locale, ok, err := s.GetStringOk("locale"); ok && err == nil {
return locale
}
return s.Defaults.GetString("locale")
}
0