8000 [breaking] gRPC `UpdateIndex` and `UpdateLibrariesIndex` improvements by cmaglie · Pull Request #2569 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

[breaking] gRPC UpdateIndex and UpdateLibrariesIndex improvements #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 22, 2024
Merged

[breaking] gRPC UpdateIndex and UpdateLibrariesIndex improvements #2569

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a634d7
gRPC UpdateIndex and UpdateLibrariesIndex improvements
cmaglie Mar 22, 2024
7955539
Do not make any output in case of skipped/already-up-to-date
cmaglie Mar 22, 2024
e387859
Added json output to 'core update index'
cmaglie Mar 22, 2024
55c9b06
Added json output to 'lib update index'
cmaglie Mar 22, 2024
88d3207
Removed unused function
cmaglie Mar 22, 2024
e92a812
Workaround for Windows paths in URI
cmaglie Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed unused function
  • Loading branch information
@cmaglie
cmaglie committed Mar 22, 2024
commit 88d320763c783a212ddf24e50979d056692e5734
19 changes: 0 additions & 19 deletions internal/cli/lib/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ import (

"github.com/arduino/arduino-cli/commands"
"github.com/arduino/arduino-cli/commands/lib"
"github.com/arduino/arduino-cli/internal/cli/configuration"
"github.com/arduino/arduino-cli/internal/cli/feedback"
"github.com/arduino/arduino-cli/internal/cli/feedback/result"
"github.com/arduino/arduino-cli/internal/cli/instance"
rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
"github.com/arduino/go-paths-helper"
"github.com/sirupsen/logrus"
"github.com/spf13/cobra"
)
Expand Down Expand Up @@ -222,20 +220,3 @@ func (res librarySearchResult) String() string {

return out.String()
}

// indexNeedsUpdating returns whether library_index.json needs updating
func indexNeedsUpdating(timeout time.Duration) bool {
// Library index path is constant (relative to the data directory).
// It does not depend on board manager URLs or any other configuration.
dataDir := configuration.Settings.GetString("directories.Data")
indexPath := paths.New(dataDir).Join("library_index.json")
// Verify the index file exists and we can read its fstat attrs.
if indexPath.NotExist() {
return true
}
info, err := indexPath.Stat()
if err != nil {
return true
}
return time.Since(info.ModTime()) > timeout
}
0