-
-
Notifications
You must be signed in to change notification settings - Fork 407
[BREAKING] gRPC / golang Configuration API refactoring #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
8c07823
Moved a batch of function from commands/* subpackage to commands
cmaglie 3d8f50a
Moved a batch of function from commands/* subpackage to commands (par…
cmaglie 3ff8e09
Moved a batch of function from commands/* subpackage to commands (par…
cmaglie 8615985
Moved a batch of function from commands/* subpackage to commands (par…
cmaglie 61e5c46
Moved a batch of function from commands/* subpackage to commands (par…
cmaglie 9e75b4d
Removed unused parameters
cmaglie f1a015c
Removed unused file
cmaglie c4ca852
Removed ToRPCStatus in favor of standardized GRPCStatus() interface
cmaglie 23ccd43
Inlining methods in ArduinoCoreServiceImpl (part 1: BoardListAll)
cmaglie 53f03e5
Inlining methods in ArduinoCoreServiceImpl (part 2: BoardDetails)
cmaglie 0df2149
Inlining methods in ArduinoCoreServiceImpl (part 3: BoardList)
cmaglie f65eff2
Inlining methods in ArduinoCoreServiceImpl (part 4: BoardListWatch)
cmaglie 06d6842
Inlining methods in ArduinoCoreServiceImpl (part 5: Create and Destroy)
cmaglie 8bd0eef
Follow convetion where context must be the first argument
cmaglie a81069d
Inlining methods in ArduinoCoreServiceImpl (part 6: Init)
cmaglie 917dcc5
Inlining methods in ArduinoCoreServiceImpl (part 7: UpdateIndex)
cmaglie bb815cf
Inlining methods in ArduinoCoreServiceImpl (part 8: Monitor)
cmaglie 0e434f2
Inlining methods in ArduinoCoreServiceImpl (part 9: Compile)
cmaglie 12cf52e
Inlining methods in ArduinoCoreServiceImpl (part 10: PlatformInstall,…
cmaglie cfe4b27
Inlining methods in ArduinoCoreServiceImpl (part 11: LibraryDownload,…
cmaglie a3800fa
Inlining methods in ArduinoCoreServiceImpl (part 12: UpdateLibrariesI…
cmaglie 738ad7c
Inlining methods in ArduinoCoreServiceImpl (part 13: NewSketch, LoadS…
cmaglie 0442319
Inlining methods in ArduinoCoreServiceImpl (part 14: Upload, UploadUs…
cmaglie 65ecbaf
Inlining methods in ArduinoCoreServiceImpl (part 15: SupportedUserFie…
cmaglie 0bdc07a
Inlining methods in ArduinoCoreServiceImpl (part 16: CleanDownloadCac…
cmaglie 3193b7c
Made utility functions private and put them in their own file
cmaglie c08c59e
Run tests forcing the english language
cmaglie e8e1574
Use correct env var to force configuration in integration test
cmaglie 9bab3c5
Fixed markdown link
cmaglie 6320f6e
Always use arduino-cli in user-agent string
cmaglie 1fddba7
Removed global *viper.Viper settings instance
cmaglie 4c50868
Implementation of Viper replacement library
cmaglie 0453677
Use custom type to avoid context-values collisions
cmaglie 61b66a7
Fixed test
cmaglie 087a6f5
Fixed FindConfigFileInArgsFallbackOnEnv unit test
cmaglie 9cd9c97
Fixed TestUserAgentHeader and TestProxy
cmaglie 384c30c
Improved error message
cmaglie 6aa742f
Config set adds only unique values
cmaglie 0aafda3
Fixed initialization sequence for 'config init' command
cmaglie 921fa61
Config search now looks into ARDUINO_DIRECTORIES_DATA env too
cmaglie ad8dbd9
Fixed all config* integration test
cmaglie 4061131
Added missing type schema
cmaglie fa835de
Added docs
cmaglie 72e05ee
Updated documentation about configuration file format
cmaglie 89a79cb
Fixed a small imperfection in test
cmaglie 240c8b3
Pass context in upload and burn-bootloader
cmaglie 24ac040
Pass down context in all places where it's needed
cmaglie 6cf4eb7
Removed unused parameter
cmaglie 27e9c3e
Tolerate errors in invalid config files, and report them as warnings
cmaglie 7658db6
Improved handling of incomplete configs array
cmaglie a58c350
Disable logging until it is setup in the arduino-cli pre-run
cmaglie 9585728
Show config-load warning after feedback package initialization
cmaglie b279d4b
Fixed 'feedback' package initialization order
cmaglie 278a331
Applied changes from code review
cmaglie c355478
Updated client_example
cmaglie cec1fdb
Improved array handling in configmap, and unit-tests
cmaglie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Improved error message
- Loading branch information
commit 384c30c86c39a85b5cb24f7dfe8c1411edbf88ba
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.