8000 feat: added more `debug` options by cmaglie · Pull Request #2356 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

feat: added more debug options #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 9, 2023
Merged

feat: added more debug options #2356

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4c6e007
Improved specification of debug configuration
cmaglie Oct 4, 2023
8e0e201
Added integration test
cmaglie Oct 4, 2023
78197c0
Added the possibility to provide cortex-debug custom configs
cmaglie Oct 4, 2023
9bf1523
Added svd-file debug option
cmaglie Oct 4, 2023
a015979
Added textual print of custom cortex-debug config
cmaglie Oct 4, 2023
510ae54
Updated docs
cmaglie Oct 5, 2023
32d46c0
Apply suggestions from code review
cmaglie Oct 9, 2023
f088a76
Added integration test for programmer selection
cmaglie Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com>
  • Loading branch information
@cmaglie @umbynos
cmaglie and umbynos authored Oct 9, 2023
commit 32d46c03eda6dec26e8b1733ceaad5cb31a102bf
3 changes: 1 addition & 2 deletions docs/platform-specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,7 +1357,7 @@ directives:
- `debug.server`: is a unique identifier of the required debug server, currently we support only `openocd`
- `debug.svd_file`: is the absolute path to the SVD descriptor.

OpenOCD server specific confgiurations:
OpenOCD server specific configurations:

- `debug.server.openocd.path`: is the absolute path to the OpenOCD directory
- `debug.server.openocd.scripts_dir`: is the absolute path to the OpenOCD scripts directory
Expand Down Expand Up @@ -1389,7 +1389,6 @@ will result in the following JSON to be merged in the Arduino IDE generated `lau

```json
{
"anotherStringParamer": "hellooo",
"overrideRestartCommands": ["monitor reset halt", "monitor gdb_sync", "thb setup", "c"],
"postAttachCommands": [
"set remote hardware-watchpoint-limit 2",
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/debug/debug.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ type openOcdServerConfigResult struct {
}

func newDebugInfoResult(info *rpc.GetDebugConfigResponse) *debugInfoResult {
var toolchaingConfig interface{}
var toolchainConfig interface{}
var serverConfig interface{}
switch info.Server {
case "openocd":
Expand All @@ -160,7 +160,7 @@ func newDebugInfoResult(info *rpc.GetDebugConfigResponse) *debugInfoResult {
Toolchain: info.Toolchain,
ToolchainPath: info.ToolchainPath,
ToolchainPrefix: info.ToolchainPrefix,
ToolchainConfig: toolchaingConfig,
ToolchainConfig: toolchainConfig,
Server: info.Server,
ServerPath: info.ServerPath,
ServerConfig: serverConfig,
Expand Down
0