8000 Upload port detector improvements by cmaglie · Pull Request #2288 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Upload port detector improvements #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Upload port detector improvements #2288

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54b7b94
If the upload port-detector fails detection, fallback to the user-pro…
cmaglie Aug 31, 2023
b4c02b9
Increased debug level
cmaglie Aug 31, 2023
7c77ed2
Extend timeout if candidate port is lost in any case
cmaglie Aug 31, 2023
0ff1377
Revert "Extend timeout if candidate port is lost in any case"
cmaglie Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "Extend timeout if candidate port is lost in any case" 
This reverts commit 7c77ed2.

The latest commit is not necessary since the detector has already 5 seconds of timeout.
  • Loading branch information
@cmaglie
cmaglie committed Aug 31, 2023
commit 0ff1377aced6a59fa3c583718585194773ed9219
3 changes: 0 additions & 3 deletions commands/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,9 +575,6 @@ func detectUploadPort(
waitForUploadPort = true
timeout = time.After(5 * time.Second)
log.Debug("User-specified port has been disconnected, now waiting for upload port, timeout extended by 5 seconds")
} else {
timeout = time.After(time.Second)
log.Debug("Candidate port has been disconnected, timeout extended by 1 second")
}
continue
}
Expand Down
0