8000 Add Delete command to gRPC by MatteoPologruto · Pull Request #2212 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Add Delete command to gRPC #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Add Delete command to gRPC #2212

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a04d89
Add DeleteRequest and DeleteResponse to gRPC
MatteoPologruto Jun 7, 2023
85956f0
Add Delete command to settings
MatteoPologruto Jun 7, 2023
2ef668c
Add TestDelete to settings_test.go
MatteoPologruto Jun 12, 2023
933554a
Remove temporary directory when TestWrite ends
MatteoPologruto Jun 13, 2023
9ae9461
Refactor `config delete` command using gRPC function call
MatteoPologruto Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add DeleteRequest and DeleteResponse to gRPC
  • Loading branch information
@MatteoPologruto
MatteoPologruto committed Jun 27, 2023
commit 7a04d8929aaa4bc7871a5ad7b9aac10995522556
227 changes: 175 additions & 52 deletions rpc/cc/arduino/cli/settings/v1/settings.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion rpc/cc/arduino/cli/settings/v1/settings.proto
View file
Open in desktop
835C
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ service SettingsService {

// Writes to file settings currently stored in memory
rpc Write(WriteRequest) returns (WriteResponse);

// Deletes an entry and rewrites the file settings
rpc Delete(DeleteRequest) returns (DeleteResponse);
}

message GetAllResponse {
Expand Down Expand Up @@ -78,4 +81,11 @@ message WriteRequest {
string file_path = 1;
}

message WriteResponse {}
message WriteResponse {}

message DeleteRequest {
// The key of the setting to delete.
string key = 1;
}

message DeleteResponse {}
Loading
0