8000 refactoring: Fixing legacy pathnames by cmaglie · Pull Request #2038 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

refactoring: Fixing legacy pathnames #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 27, 2023
Merged

refactoring: Fixing legacy pathnames #2038

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2bc861
Removed builderCtx.BuildCachePath
cmaglie Jan 18, 2023
03901e9
Removed useless assignment
cmaglie Jan 19, 2023
d2aea4a
Do not store sketch build-path but generate it on demand
cmaglie Jan 19, 2023
ac43ceb
Removed redundant SketchLocation field and related subroutines
cmaglie Jan 19, 2023
9fd565d
Replaced deprecated calls (from go linter)
cmaglie Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed useless assignment
  • Loading branch information
@cmaglie
cmaglie committed Jan 27, 2023
commit 03901e919f544fbe032521a18cd982f06c967fbf
4 changes: 1 addition & 3 deletions legacy/builder/sketch_loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,12 @@ func (s *SketchLoader) Run(ctx *types.Context) error {
sketchLocation = sketchLocation.Join(mainSketchStat.Name() + ".ino")
}

ctx.SketchLocation = sketchLocation

sketch, err := sk.New(sketchLocation)
if err != nil {
return errors.WithStack(err)
}

ctx.SketchLocation = sketchLocation
ctx.Sketch = sketch

return nil
}
0