add completion for -l or --protocol

But does only work for connected boards and do not list every protocol installed
arduino · umbynos · Oct 18, 2021 · Oct 18, 2021 · Oct 18, 2021 · Oct 5, 2021
commit b7263bfed9f7d8aa25084748fdb0a6700927bb03
diff --git a/cli/arguments/completion.go b/cli/arguments/completion.go
@@ -26,3 +26,18 @@ func GetInstalledBoards(toComplete string) []string {
 	}
 	return res
 }
+
+// GetInstalledProtocols is an helper function usefull to autocomplete.
+// It returns a list of protocols available
+func GetInstalledProtocols(toComplete string) []string {
+	inst := instance.CreateAndInit() // TODO optimize this: it does not make sense to create an instance everytime
+
+	detectedBoards, _ := board.List(&rpc.BoardListRequest{
+		Instance: inst,
+	})
+	var res []string
+	for _, i := range detectedBoards {
+		res = append(res, i.Port.Protocol)
+	}
+	return res
+}
diff --git a/cli/arguments/port.go b/cli/arguments/port.go
@@ -43,6 +43,9 @@ type Port struct {
 func (p *Port) AddToCommand(cmd *cobra.Command) {
 	cmd.Flags().StringVarP(&p.address, "port", "p", "", tr("Upload port address, e.g.: COM3 or /dev/ttyACM2"))
 	cmd.Flags().StringVarP(&p.protocol, "protocol", "l", "", tr("Upload port protocol, e.g: serial"))
+	cmd.RegisterFlagCompletionFunc("protocol", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		return GetInstalledProtocols(toComplete), cobra.ShellCompDirectiveDefault
 	})
 	cmd.Flags().DurationVar(&p.timeout, "discovery-timeout", 5*time.Second, tr("Max time to wait for port discovery, e.g.: 30s, 1m"))
 }
 

diff --git a/i18n/data/en.po b/i18n/data/en.po
@@ -1418,7 +1418,7 @@ msgstr "Low memory available, stability problems may occur."
 msgid "Maintainer: %s"
 msgstr "Maintainer: %s"
 
-#: cli/arguments/port.go:46
+#: cli/arguments/port.go:49
 msgid "Max time to wait for port discovery, e.g.: 30s, 1m"
 msgstr "Max time to wait for port discovery, e.g.: 30s, 1m"
 
@@ -3031,7 +3031,7 @@ msgstr "pluggable discovery already added: %s"
 msgid "port"
 msgstr "port"
 
-#: cli/arguments/port.go:122
+#: cli/arguments/port.go:125
 msgid "port not found: %[1]s %[2]s"
 msgstr "port not found: %[1]s %[2]s"