8000 Pass of lint for .proto files by cmaglie · Pull Request #1223 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Pass of lint for .proto files #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 29, 2021
Merged

Pass of lint for .proto files #1223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5ad5808
Added linter ignore rules to match current .proto files
cmaglie Mar 15, 2021
9bd20a3
Fixed SERVICE_SUFFIX lint warning
cmaglie Mar 15, 2021
208adaf
Fixed RPC_RESPONSE_STANDARD_NAME lint warning
cmaglie Mar 15, 2021
2447395
Fixed RPC_REQUEST_STANDARD_NAME and RPC_REQUEST_RESPONSE_UNIQUE lint …
cmaglie Mar 15, 2021
b95dbaa
Fixed ENUM_VALUE_PREFIX and ENUM_VALUE_UPPER_SNAKE_CASE lint warning
cmaglie Mar 15, 2021
34e70b8
Fixed FIELD_LOWER_SNAKE_CASE lint warning
cmaglie Mar 15, 2021
15ec6e9
Fixed PACKAGE_VERSION_SUFFIX lint warning
cmaglie Mar 15, 2021
d579f90
Fixed PACKAGE_DIRECTORY_MATCH lint warning
cmaglie Mar 15, 2021
29ba30f
Fixed plurals in repeated fields
cmaglie Mar 17, 2021
c6eb5ec
Fixed .proto files indentations
cmaglie Mar 17, 2021
91711db
Fixed some multiword names
cmaglie Mar 17, 2021
13a8b08
Pass of clang-format
cmaglie Mar 17, 2021
2b1401f
Fixed integration tests for JSON output
cmaglie Mar 18, 2021
2fc7a81
Updated example_client
cmaglie Mar 18, 2021
39ef78d
Rename archive_file_name to archive_filename for coherence with the r…
cmaglie Mar 23, 2021
79d4398
Updated migration guide
cmaglie Mar 23, 2021
23fa492
Added lint and format as Taskfile targets
cmaglie Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed .proto files indentations
  • Loading branch information
@cmaglie
cmaglie committed Mar 24, 2021
commit c6eb5ec5d430862b8264a316397fef4703356461
332 changes: 165 additions & 167 deletions rpc/cc/arduino/cli/commands/v1/board.proto
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 7 additions & 4 deletions rpc/cc/arduino/cli/commands/v1/commands.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ message DestroyRequest {
// The Arduino Core Service instance to destroy.
Instance instance = 1;
}
message DestroyResponse {}

message DestroyResponse {
}

message RescanRequest {
// Arduino Core Service instance from the Init response.
Expand Down Expand Up @@ -237,7 +239,6 @@ message OutdatedResponse {
message UpgradeRequest {
// Arduino Core Service instance from the Init response.
Instance instance = 1;

// Set to true to not run (eventual) post install scripts
bool skip_post_install = 2;
}
Expand All @@ -249,7 +250,8 @@ message UpgradeResponse {
TaskProgress task_progress = 2;
}

message VersionRequest {}
message VersionRequest {
}

message VersionResponse {
// The version of Arduino CLI in use.
Expand Down Expand Up @@ -285,4 +287,5 @@ message ArchiveSketchRequest{
bool include_build_dir = 3;
}

message ArchiveSketchResponse { }
message ArchiveSketchResponse {
}
86 changes: 43 additions & 43 deletions rpc/cc/arduino/cli/commands/v1/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,21 @@ package cc.arduino.cli.commands.v1;
option go_package = "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1;commands";

message Instance {
// The ID of the instance.
int32 id = 1;
// The ID of the instance.
int32 id = 1;
}

message DownloadProgress {
// URL of the download.
string url = 1;
// The file being downloaded.
string file = 2;
// Total size of the file being downloaded.
int64 total_size = 3;
// Size of the downloaded portion of the file.
int64 downloaded = 4;
// Whether the download is complete.
bool completed = 5;
// URL of the download.
string url = 1;
// The file being downloaded.
string file = 2;
// Total size of the file being downloaded.
int64 total_size = 3;
// Size of the downloaded portion of the file.
int64 downloaded = 4;
// Whether the download is complete.
bool completed = 5;
}

message TaskProgress {
Expand All @@ -47,41 +47,41 @@ message TaskProgress {
}

message Programmer {
string platform = 1;
string id = 2;
string name = 3;
string platform = 1;
string id = 2;
string name = 3;
}

message Platform {
// Platform ID (e.g., `arduino:avr`).
string id = 1;
// Version of the platform.
string installed = 2;
// Newest available version of the platform.
string latest = 3;
// Name used to identify the platform to humans (e.g., "Arduino AVR Boards").
string name = 4;
// Maintainer of the platform's package.
string maintainer = 5;
// A URL provided by the author of the platform's package, intended to point
// to their website.
string website = 6;
// Email of the maintainer of the platform's package.
string email = 7;
// List of boards provided by the platform. If the platform is installed,
// this is the boards listed in the platform's boards.txt. If the platform is
// not installed, this is an arbitrary list of board names provided by the
// platform author for display and may not match boards.txt.
repeated Board boards = 8;
// If true this Platform has been installed manually in the user' sketchbook
// hardware folder
bool manually_installed = 9;
// Platform ID (e.g., `arduino:avr`).
string id = 1;
// Version of the platform.
string installed = 2;
BD62 // Newest available version of the platform.
string latest = 3;
// Name used to identify the platform to humans (e.g., "Arduino AVR Boards").
string name = 4;
// Maintainer of the platform's package.
string maintainer = 5;
// A URL provided by the author of the platform's package, intended to point
// to their website.
string website = 6;
// Email of the maintainer of the platform's package.
string email = 7;
// List of boards provided by the platform. If the platform is installed,
// this is the boards listed in the platform's boards.txt. If the platform is
// not installed, this is an arbitrary list of board names provided by the
// platform author for display and may not match boards.txt.
repeated Board boards = 8;
// If true this Platform has been installed manually in the user' sketchbook
// hardware folder
bool manually_installed = 9;
}

message Board {
// Name used to identify the board to humans.
string name = 1;
// Fully qualified board name used to identify the board to machines. The FQBN
// is only available for installed boards.
string fqbn = 2;
// Name used to identify the board to humans.
string name = 1;
// Fully qualified board name used to identify the board to machines. The FQBN
// is only available for installed boards.
string fqbn = 2;
}
89 changes: 64 additions & 25 deletions rpc/cc/arduino/cli/commands/v1/compile.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
0