8000 Don't archive preexisting archives if commandline is too long by facchinm · Pull Request #1140 · arduino/arduino-cli · GitHub
[go: up one dir, main page]
Skip to content

Don't archive preexisting archives if commandline is too long #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Don't archive preexisting archives if commandline is too long #1140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04f078b
Don't archive preexisting archives if commandline is too long
facchinm Jan 15, 2021
eb1195d
Added test
cmaglie Jan 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't archive preexisting archives if commandline is too long 
Fixes https://github.com/arduino-libraries/ArduinoIoTCloud/runs/1693000682?check_suite_focus=true#step:7:277
Should revert arduino-libraries/ArduinoIoTCloud#222
  • Loading branch information
@facchinm
facchinm committed Jan 15, 2021
commit 04f078b0b8c34048dcc024cdcfe8656105b50af5
4 changes: 4 additions & 0 deletions legacy/builder/phases/linker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ func link(ctx *types.Context, objectFiles paths.PathList, coreDotARelPath *paths
properties := buildProperties.Clone()
archives := paths.NewPathList()
for _, object := range objectFiles {
if object.HasSuffix(".a") {
archives.Add(object)
continue
}
archive := object.Parent().Join("objs.a")
if !archives.Contains(archive) {
archives.Add(archive)
Expand Down
0