8000 Use clang-format for auto-format (replaces libastyle) by cmaglie · Pull Request #11543 · arduino/Arduino · GitHub
[go: up one dir, main page]
Skip to content

Use clang-format for auto-format (replaces libastyle) #11543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Use clang-format for auto-format (replaces libastyle) #11543

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
< 8000 div class="js-diffbar-range-list" data-range-url="/arduino/Arduino/pull/11543/files/$range">
4a1ef0f
First implementation of ClangFormat class
cmaglie May 19, 2021
7ef8b06
Added clang-format download in build.xml
cmaglie May 19, 2021
f20d512
ClangFormat is no more a Tool
cmaglie May 19, 2021
d33fc4e
Fixed some trivial warnings
cmaglie May 19, 2021
1f1dc7d
Removed libastyle
cmaglie May 19, 2021
7e76bc5
Renamed some build.xml ant task from libastyle to liblistserials
cmaglie May 19, 2021
66a001c
Handle cursor positioning
cmaglie May 20, 2021
c4c5558
Slightly simplify subroutine
cmaglie May 20, 2021
321eadb
Catch clang-format error and report to user interface
cmaglie May 20, 2021
752bcdb
Added default clang-format configuration and user-customizable config…
cmaglie May 20, 2021
09c6626
Autoformat keeps cursor position after Undo
cmaglie May 21, 2021
7754b7f
Fixed tests for new autoformat style
cmaglie May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixed tests for new autoformat style
  • Loading branch information
@cmaglie
cmaglie committed May 21, 2021
commit 7754b7fc8a127b46ee099fbea8e8a71b70d3486d
2 changes: 0 additions & 2 deletions app/test/processing/app/AutoformatProducesOneUndoActionTest.java
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,10 @@ public class AutoformatProducesOneUndoActionTest extends AbstractGUITest {
"}";
public static final String SOURCE_AFTER = "void setup() {\n" +
" // put your setup code here, to run once:\n" +
"\n" +
"}\n" +
"\n" +
"void loop() {\n" +
" // put your main code here, to run repeatedly:\n" +
"\n" +
"}";

@Test
Expand Down
2 changes: 0 additions & 2 deletions app/test/processing/app/AutoformatSavesCaretPositionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,10 @@ public void shouldSaveCaretPositionAfterAutoformat() {
String formattedText = editor.getText();
assertEquals("void setup() {\n" +
" // put your setup code here, to run once:\n" +
"\n" +
"}\n" +
"\n" +
"void loop() {\n" +
" // put your main code here, to run repeatedly:\n" +
"\n" +
"}", formattedText);

// Autoformat with clang-format keeps cursor relative to source code
Expand Down
4 changes: 2 additions & 2 deletions app/test/processing/app/AutoformatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ public void shouldProduceNicelyFormattedCode() throws Exception {
String formattedText = editor.getText();
assertEquals("void setup() {\n" +
" // put your setup code here, to run once:\n" +
" int foo[] = { 1, 2, 3, 4, 5};\n" +
" int foo[2][5] = {{1, 2, 3, 4, 5}, {6, 7, 8, 9, 10}};\n" +
" int foo[] = { 1, 2, 3, 4, 5 };\n" +
" int foo[2][5] = { { 1, 2, 3, 4, 5 }, { 6, 7, 8, 9, 10 } };\n" +
"}\n" +
"\n" +
"void loop() {\n" +
Expand Down
0