8000 reland: audio & video player: migrate to common playbin implementation by ardera · Pull Request #483 · ardera/flutter-pi · GitHub
[go: up one dir, main page]

Skip to content

reland: audio & video player: migrate to common playbin implementation #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
36a2127
video player: use square BO
ardera Feb 21, 2025
0b3f3a4
video player: use playbin3 instead of uridecodebin
ardera Feb 21, 2025
2298020
video player: don't handle dma_drm video info
ardera Feb 21, 2025
ca1eee4
video player: fix code for gstreamer < 1.24.0
ardera Feb 21, 2025
58663ba
video player: fix parameter in g_object_set
ardera Feb 21, 2025
dc0ff2a
video player: disable hw decoding for gstreamer < 1.22.8
ardera May 8, 2025
ef858c0
video player: make seek flags construction a bit more easier to follow
ardera May 8, 2025
878f39c
util: add khash hashmap implementation
ardera May 8, 2025
0e6b1da
platform channels: helpers for decoding method calls
ardera May 12, 2025
5f65e73
gitignore: ignore .cache
ardera May 12, 2025
63de32b
gstplayer: feature parity with audioplayers player
ardera May 12, 2025
2f37727
audioplayers: migrate to gstplayer
ardera May 9, 2025
0740253
gstplayer: move gstplayer into separate file
ardera May 12, 2025
efab797
modesetting: remove logs if a separate cursor plane couldn't be found
ardera May 12, 2025
436f790
cmake: remove deleted `audioplayers/player.c` file
ardera May 12, 2025
c7a7493
Revert "video player: disable hw decoding for gstreamer < 1.22.8"
ardera May 13, 2025
815ac82
gstplayer: don't use gst_video_info_new_from_caps
ardera May 13, 2025
facc7fc
gstplayer: only define appsink event handler for gstreamer >= 1.20.0
ardera May 13, 2025
5e72346
gstplayer: don't use sd_event_source_disable_unref
ardera May 13, 2025
cd2c8ef
notifier/listener: fix change notifiers notifying on listen
ardera May 16, 2025
1584c59
gstplayer/audio player/video player: various compatibility fixes
ardera May 16, 2025
c2ed358
flutter-pi: allow getting tracer of flutterpi instance
ardera May 16, 2025
d008074
video player: Better feedback when trying to create pipeline video
ardera May 19, 2025
3a95567
gstplayer: re-implement creating video players from pipeline description
ardera Jun 2, 2025
4d29038
style: make bool flag arguments more readable
ardera Jun 2, 2025
98215b1
gstplayer, video player: add tracing
ardera Jun 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
notifier/listener: fix change notifiers notifying on listen
Change notifiers should only trigger when
notifier_notify is called, not on listen.
  • Loading branch information
ardera committed May 16, 2025
commit cd2c8ef16165ecba90fb5d5aaa3356e45f25e600
10 changes: 6 additions & 4 deletions src/notifier_listener.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,12 @@ struct listener *notifier_listen(struct notifier *notifier, listener_cb_t notify
return NULL;
}

r = listener_notify(l, notifier->state);
if (r == kUnlisten) {
listener_destroy(l);
return NULL;
if (notifier->is_value_notifier) {
r = listener_notify(l, notifier->state);
if (r == kUnlisten) {
listener_destroy(l);
return NULL;
}
}

notifier_lock(notifier);
Expand Down
0