8000 [DE-682] #281 better exception translation by aburmeis · Pull Request #282 · arangodb/spring-data · GitHub
[go: up one dir, main page]
Skip to content

[DE-682] #281 better exception translation #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from :feature/exception-handling
Sep 6, 2023
Merged

[DE-682] #281 better exception translation #282

merged 6 commits into from
Sep 6, 2023

Conversation

aburmeis
Copy link
Contributor
@aburmeis aburmeis commented Sep 5, 2023 •
edited
Loading

Fix for #281:

  • use recommended DataAccessUtils.translateIfNecessary()
  • handle some errors in a more specific way:
    • errorNumber 1202 as DataRetrievalFailureException
    • errorNumber 1200 and message with write-write conflict as TransientDataAccessResourceException
    • errorNumber 1200 and message with _rev conflict as OptimisticLockingFailureException
    • errorNumer 1210 and message with _key as DuplicateKeyException

@cla-bot cla-bot bot added the cla-signed label Sep 5, 2023
@aburmeis aburmeis force-pushed the feature/exception-handling branch 2 times, most recently from 20658a0 to 7017228 Compare September 6, 2023 07:54
@aburmeis aburmeis force-pushed the feature/exception-handling branch from 7017228 to 9853b2c Compare September 6, 2023 07:59
@aburmeis aburmeis marked this pull request as ready for review September 6, 2023 08:00
@rashtao rashtao self-requested a review September 6, 2023 10:44
rashtao
rashtao requested changes Sep 6, 2023
View reviewed changes
@rashtao rashtao self-requested a review September 6, 2023 12:40
@rashtao rashtao changed the title #281 better exception translation [DE-682] #281 better exception translation Sep 6, 2023
@rashtao rashtao merged commit 6c27511 into arangodb:master Sep 6, 2023
@rashtao rashtao mentioned this pull request Sep 6, 2023
Closed
@aburmeis aburmeis deleted the feature/exception-handling branch September 6, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashtao rashtao rashtao approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aburmeis @rashtao
0