8000 [DE-805] A way to check if a LazyLoadingProxy entity has been resolved · Issue #271 · arangodb/spring-data · GitHub
[go: up one dir, main page]
Skip to content

[DE-805] A way to check if a LazyLoadingProxy entity has been resolved #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mcso opened this issue Mar 16, 2023 · 3 comments
Closed

[DE-805] A way to check if a LazyLoadingProxy entity has been resolved #271

mcso opened this issue Mar 16, 2023 · 3 comments 8000
Assignees
@rashtao
Labels
enhancement

Comments

@mcso
Copy link
mcso commented Mar 16, 2023

Been playing around with the library, and has come across a situation for which I haven't found a solution for already.

When an object is a LazyLoadingProxy, it doesn't seem like there is a way to check if the entity has already been fetched from the database. Looking at AbstractResolver.ProxyInterceptor, there is a variable resolved which hold this state, but it is currently not exposed.
Is there a better way to check if the entity has been resolved, or can this be exposed through the LazyLoadingProxy interface?

This could be useful in situations like mapping with MapStruct (or other similar libaries) where a conditional mapping could be made, so it would only do the mapping if the entity has been resolved. Right now it will access the proxy object, which will trigger resolving the object from the database.
Hibernate's LazyInitializer has a similar method (isUninitialized()) for doing this kind of check.

I am using arangodb-spring-data version: 3.8.0.
@rashtao rashtao self-assigned this Apr 4, 2023
@rashtao
Copy link
Collaborator
rashtao commented Apr 4, 2023

Thanks for reporting, we can implement this by exposing the resolved field:

spring-data/src/main/java/com/arangodb/springframework/core/convert/resolver/AbstractResolver.java

Line 112 in 706a61f

private volatile boolean resolved;

in LazyLoadingProxy.

@mdmm13
Copy link
mdmm13 commented Feb 8, 2024

We've got the same issue where MapStruct causes tons of non-instantiated proxy objects to be called. This variable would greatly reduce the complexity of the checks.

@rashtao rashtao changed the title A way to check if a LazyLoadingProxy entity has been resolved [DE-805] A way to check if a LazyLoadingProxy entity has been resolved Apr 23, 2024
rashtao added a commit that referenced this issue Apr 25, 2024
@rashtao
added LazyLoadingProxy.isResolved() (DE-805, #271)
720f52a
@rashtao
Copy link
Collaborator
rashtao commented Jun 21, 2024

released in https://github.com/arangodb/spring-data/releases/tag/v4.2.0

@rashtao rashtao closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rashtao rashtao

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rashtao @mcso @mdmm13
0