Failing Pregel Doctest #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 26 26
Lines 4240 4240
=======================================
Hits 4156 4156
Misses 84 84 ☔ View full report in Codecov by Sentry. |
aMahanna
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Pregel is deprecated since ArangoDB 3.12, its doctest will start failing as new arangodb docker images get released (our doctest config always pulls
arangodb/arangodb:latest).I suggest we still keep the Pregel examples for now, but mark it as
code-blockinstead oftestcode, as the API is still usable with supported versions (3.10 and 3.11).Also, there is a small issue with the order of operations in the
transactions.rstexample. One of the newly created transactions was neither aborted not committed. I fixed that by moving the last added example towards the end and I explicitly aborted the transaction.