8000 Introducing Replicated Logs by goedderz · Pull Request #327 · arangodb/oskar · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@goedderz
Copy link
Member
@goedderz goedderz commented Jun 29, 2021

Companion PR of arangodb/arangodb#14486.

This PR must not be merged before #14486, but can safely be merged later. It enables tests that are only necessary for things introduced by #14486.

@goedderz goedderz self-assigned this Jun 29, 2021
@goedderz goedderz changed the title Feature/replication 2.0 Introducing Replicated Logs Jun 29, 2021
@goedderz goedderz marked this pull request as ready for review August 10, 2021 13:59
@goedderz
Copy link
Member Author

Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me however someone with more Oskar experience should take a better look at this.

@jsteemann
Copy link
Contributor

Note the future reviewers: the test suite replication2_client is already blocklisted in 3.6, 3.7 and 3.8.

Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goedderz
Copy link
Member Author

@mchacki mchacki merged commit 14f592a into master Aug 13, 2021
@mchacki mchacki deleted the feature/replication-2.0 branch August 13, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0