8000 Bug fix/curb aardvark foxx cthulhu by pluma · Pull Request #9867 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix/curb aardvark foxx cthulhu #9867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2019
Merged

Bug fix/curb aardvark foxx cthulhu #9867

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d894d40
Revert "fixed ui behaviour when replacing a foxx app"
pluma Aug 30, 2019
7fb8d3e
Cleanup on aisle 3
pluma Aug 30, 2019
a62aee6
Typo
pluma Aug 30, 2019
80a0d2b
Fixed param order
pluma Aug 30, 2019
51ca064
Cleanup flags
pluma Aug 30, 2019
17f10e2
Actually use the queryParams
pluma Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed param order
  • Loading branch information
@pluma
pluma committed Aug 30, 2019
commit 80a0d2bda151406d20dcc985d08b0872083cd53b
2 changes: 1 addition & 1 deletion js/apps/system/_admin/aardvark/APP/frontend/js/collections/foxxCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
this.sortOptions.desc = val;
},

install: function (info, mount, callback, mode, options) {
install: function (mode, info, mount, options, callback) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods all did the same thing except using slightly different URLs. We now pass the bit in the URL that changes in the arguments as "mode".

var url = arangoHelper.databaseUrl('/_admin/aardvark/foxxes/' + mode + '?mount=' + encodeURIComponent(mount));
if (options.legacy) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legacy flag has now been merged into the other option flags.

url += '&legacy=true';
Expand Down
0