8000 [3.5] Check scheduler queue return value by dhly-etc · Pull Request #9759 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[3.5] Check scheduler queue return value #9759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2019
Merged

[3.5] Check scheduler queue return value #9759

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c36821
Add to cmake.
Aug 19, 2019
5b0b3ea
Backport changes from devel.
Aug 19, 2019
3d7f27b
Merge branch '3.5' of github.com:arangodb/arangodb into feature-3.5/c…
jsteemann Aug 20, 2019
1f816e6
added CHANGELOG entry, port adjustments from devel
jsteemann Aug 20, 2019
4871113
Merge branch '3.5' into feature-3.5/check-scheduler-queue-return
KVS85 Aug 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch '3.5' into feature-3.5/check-scheduler-queue-return
  • Loading branch information
@KVS85
KVS85 authored Aug 20, 2019
commit 4871113e4accba78d2d3b8a90abf8fab48fcece5
26 changes: 19 additions & 7 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,25 @@ v3.5.1 (XXXX-XX-XX)
-------------------

* Consistently honor the return value of all attempts to queue tasks in the
internal scheduler. Previously some call sites did not check the return value
of internal queueing operations, and if the scheduler queue was full, operations
that were thought to be requeued were silently dropped. Now, there will be
reactions on such failures. Requeuing an important task with a time offset
(Scheduler::queueDelay) is now also retried on failure (queue full) up to
at most five minutes. If after five minutes such a task still cannot be
queued, a fatal error will be logged and the server process will be aborted.
internal scheduler.

Previously some call sites did not check the return value of internal queueing
operations, and if the scheduler queue was full, operations that were thought
to be requeued were silently dropped. Now, there will be reactions on such
failures. Requeuing an important task with a time offset (Scheduler::queueDelay)
is now also retried on failure (queue full) up to at most five minutes. If after
five minutes such a task still cannot be queued, a fatal error will be logged
and the server process will be aborted.

* Made index selection much more deterministic in case there are
multiple competing indexes.

* Fixed issue #9654: honor value of `--rocksdb.max-write-buffer-number` if it
is set to at least 9 (which is the recommended value). Ignore it if it is
set to a lower value than 9, and warn the end user about it.

Previous versions of ArangoDB always silently ignored the value of this setting
and effectively hard-coded the value to 9.

* Fixed internal issue #4378: fix bug in MoveShard::abort which causes a
duplicate entry in the follower list.
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.
0