8000 issue #9654: make `--rocksdb.max-write-buffer-number` work by jsteemann · Pull Request #9751 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

issue #9654: make --rocksdb.max-write-buffer-number work #9751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2019
Merged

issue #9654: make --rocksdb.max-write-buffer-number work #9751

merged 3 commits into from
Aug 20, 2019

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Honor user-defined values for --rocksdb.max-write-buffer-number if within an acceptable range (i.e. 9 or greater). Ignore values that don't make sense.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Related Information

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5763/

@jsteemann jsteemann added this to the 3.5 milestone Aug 19, 2019
matthewvon
matthewvon suggested changes Aug 19, 2019
View reviewed changes
@jsteemann
Copy link
Contributor Author

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5769/

@jsteemann
Copy link
Contributor Author
jsteemann commented Aug 19, 2019 •
edited
Loading

https://172.16.10.101/view/PR/job/arangodb-matrix-pr/5777/
(tests blue)

@KVS85 KVS85 merged commit 0f03655 into 3.5 Aug 20, 2019
@fceller fceller deleted the bug-fix-3.5/issue-9654 branch September 6, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewvon matthewvon matthewvon approved these changes

@KVS85 KVS85 KVS85 approved these changes

@Simran-B Simran-B Awaiting requested review from Simran-B

Assignees
No one assigned
Labels
9 Ready to Merge
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @matthewvon @KVS85
0