8000 Deprecate rocksdb.max-write-buffer-number startup option by Simran-B · Pull Request #9654 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Deprecate rocksdb.max-write-buf 8000 fer-number startup option #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2019
Merged

Deprecate rocksdb.max-write-buffer-number startup option #9654

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d839e9e
Deprecate for v3.4.8 and v3.5.0
Simran-B Aug 7, 2019
b7a42a4
Update RocksDBOptionFeature.cpp
Simran-B Aug 7, 2019
72d2af1
Update RocksDBOptionFeature.cpp
Simran-B Aug 30, 2019
b765799
Merge remote-tracking branch 'origin/devel' into deprecate-rocksdb-ma…
Simran-B Oct 9, 2019
e45cf42
File moved
Simran-B Oct 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update RocksDBOptionFeature.cpp
  • Loading branch information
@Simran-B
Simran-B authored Aug 7, 2019
commit b7a42a49a289284e25eceeb1c53989289d7fd3fe
3 changes: 2 additions & 1 deletion lib/ApplicationFeatures/RocksDBOptionFeature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ void RocksDBOptionFeature::collectOptions(std::shared_ptr<ProgramOptions> option
options->addOption("--rocksdb.max-write-buffer-number",
"maximum number of write buffers that build up in memory. "
"This option is ignored! There is a hardcoded maximum of "
"column families+2 (currently 9) based on performance research",
"number of column families + 2 (currently 9) write buffers "
"based on performance research",
new UInt64Parameter(&_maxWriteBufferNumber))
.setDeprecatedIn(30408)
.setDeprecatedIn(30500);
Expand Down
0