-
Notifications
You must be signed in to change notification settings - Fork 858
Bug fix 3.5/min replication factor #9524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
88898e5
Cherry-pick minReplicationFactor
mchacki e1b4318
Bug fix/failover with min replication factor (#9486)
mchacki 676dacb
Removed merge conflict leftovers 0o, i should not trust the IDE
mchacki c0a2f49
Update js/apps/system/_admin/aardvark/APP/frontend/js/views/collectio…
mchacki ac7c442
Update js/apps/system/_admin/aardvark/APP/frontend/js/views/collectio…
mchacki 217a97e
Update Documentation/Books/Manual/Architecture/Replication/README.md
KVS85 1e30086
Update CHANGELOG
KVS85 28da794
Update Documentation/Books/Manual/DataModeling/Collections/DatabaseMe…
KVS85 9cba4e8
Update Documentation/Books/Manual/ReleaseNotes/NewFeatures35.md
KVS85 dde5733
Update Documentation/DocuBlocks/Rest/Collections/1_structs.md
KVS85 0b2a9fd
Update js/apps/system/_admin/aardvark/APP/frontend/js/views/graphMana…
KVS85 991e886
Update js/apps/system/_admin/aardvark/APP/frontend/js/views/graphMana…
KVS85 abd5bf1
Update Documentation/DocuBlocks/Rest/Graph/1_structs.md
mchacki 8154144
Apply suggestions from code review
mchacki 4c6685e
Adepted review requests, thanks for finding!
mchacki 8b106c7
Merge branch 'bug-fix-3.5/minReplicationFactor' of ssh://github.com/a…
mchacki 4216052
Removed unnecessary const
mchacki 314600a
Apply suggestions from code review
mchacki 28e54e7
Moved initilization of variable more downwards
mchacki a284e66
Apply lock before notify_all()
mchacki 0144f4e
Remove documentation except DocuBlocks, covered by PR in docs repo
Simran-B 70c2b0f
Remove accidental indent
Simran-B ecc031e
Merge branch '3.5' into bug-fix-3.5/minReplicationFactor
KVS85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,7 +55,7 @@ In a cluster setup, the result will also contain the following attributes: | |
on different DBServers. Has to be in the range of 1-10 *(Cluster only)* | ||
|
||
* *minReplicationFactor* : determines the number of minimal shard copies kept on | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should probably not be indented |
||
different DBServers, a shard will refuse to write, if less then this amount | ||
different DBServers, a shard will refuse to write if less than this amount | ||
of copies are in sync. Has to be in the range of 1-replicationFactor *(Cluster only)* | ||
|
||
* *shardingStrategy*: the sharding strategy selected for the collection. | ||
|
@@ -81,8 +81,8 @@ one or more of the following attribute(s): | |
different DBServers, valid values are integer numbers | ||
in the range of 1-10 *(Cluster only)* | ||
|
||
* *minReplicationFactor* : Change the number of minimal shard copies kept on | ||
different DBServers, a shard will refuse to write, if less then this amount | ||
* *minReplicationFactor* : Change the number of minimal shard copies to be in sync on | ||
different DBServers, a shard will refuse to write if less than this amount | ||
of copies are in sync. Has to be in the range of 1-replicationFactor *(Cluster only)* | ||
|
||
**Note**: some other collection properties, such as *type*, *isVolatile*, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.