Bug fix 3.4: verify communication thread has fully stopped in ClusterComm #7232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usterComm is stopped.
8000
|
http://172.16.10.101:8080/job/arangodb-matrix-pr-linux/2982/ ... running ... finished, all blue balls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is believed to address the segfault discussed here:
https://github.com/arangodb/release-3.4/issues/127
The original ClusterComm::stopBackgroundThreads() did not actually guarantee that the Communicator object on the background thread had stopped. This appears to have allowed the background thread to continue posting response tasks to Supervisor after Supervisor was destroyed. Segfaults happen.
Background thread stopping happens in two steps. First tell all threads to stop. This allows parallel shutdown activity. Second, check each thread to see that it has stopped and wait until it does.