8000 Bug fix 3.4: verify communication thread has fully stopped in ClusterComm by matthewvon · Pull Request #7232 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Bug fix 3.4: verify communication thread has fully stopped in ClusterComm #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

Bug fix 3.4: verify communication thread has fully stopped in ClusterComm #7232

merged 1 commit into from
Nov 5, 2018

Conversation

matthewvon
Copy link
Contributor
@matthewvon matthewvon commented Nov 5, 2018 •
edited
Loading

This change is believed to address the segfault discussed here:

https://github.com/arangodb/release-3.4/issues/127

The original ClusterComm::stopBackgroundThreads() did not actually guarantee that the Communicator object on the background thread had stopped. This appears to have allowed the background thread to continue posting response tasks to Supervisor after Supervisor was destroyed. Segfaults happen.

Background thread stopping happens in two steps. First tell all threads to stop. This allows parallel shutdown activity. Second, check each thread to see that it has stopped and wait until it does.

@ghost ghost assigned matthewvon Nov 5, 2018
@ghost ghost added the 2 - Working label Nov 5, 2018
@matthewvon matthewvon requested a review from neunhoef November 5, 2018 21:14
@matthewvon
Copy link
Contributor Author
matthewvon commented Nov 5, 2018 •
edited
Loading

http://172.16.10.101:8080/job/arangodb-matrix-pr-linux/2982/ ... running ... finished, all blue balls

neunhoef
neunhoef approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewvon matthewvon merged commit d4c8b43 into 3.4 Nov 5, 2018
@ghost ghost removed the 2 - Working label Nov 5, 2018
@matthewvon matthewvon mentioned this pull request Dec 10, 2018
Merged
@fceller fceller deleted the bugfix-3.4/mv-clustercommthread-stop branch January 19, 2019 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees

@matthewvon matthewvon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewvon @neunhoef
0