Bug fix/fix ssl vst #6547
Merged
Bug fix/fix ssl vst #6547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graetzer
approved these changes
Sep 19, 2018
ObiWahn
added a commit
that referenced
this pull request
Sep 24, 2018
…st-168 * 'devel' of https://github.com/arangodb/arangodb: Add simple Future library (#6464) More known issues for ArangoSearch in 3.4 (#6567) cleanoutServer Bug Fix (#6537) Do not retry connect on canceled connections (#6559) fix undefined behavior in query cache result handling (#6544) fix dependencies of init-database feature/serverid feature fix possible illegal access (#6556) safety first: turn off sync/async mixing for HTTPS in general Doc - Fix Active-Failover limitations (#6353) silence a compile warning about potential string value truncation follow compiler's recommendation Resilience test failure points (#6539) Feature/optimize arangosearch block (#6550) Fix single shard restriction with binary and. (#6549) add rocksdb::PinnableSlice for some key lookups (#6530) Bug fix/fix ssl vst (#6547) Bug fix/fix stats on skip (#6531) forward-port range deletion fix from upstream RocksDB (#6535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be over-pessimizing the SSL+VST case a bit, but it seems to improve the situation and also seems to be a safe fix.
In case the same fix is needed for HTTP+JSON, we can simply fix it by adjusting a single line in
HttpCommTask::canUseMixedIO().