BugFix 3.3: adjust SetThrottle() to only call GetDelayToken() first time. #5854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll disrupts throttle timing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SetThrottle() routine previously replaced its DelayToken every time called. This procedure was intended to keep our calculated bytes-per-second active instead of any other value that rocksdb's code might subsequently set. Unfortunately, The GetDelayToken() code within rocksdb also clears all timings currently in use and forces a big wait upon the very next write. This could happen multiple times a second under heavy load.
The code now retrieves a DelayToken only if one is not previously held. Subsequent rewrites of our bytes-per-second value now use a different API that does not clear current timings.